Twenty Twenty-One get_attachment_image_attributes_image_attributes not checking if variable isset properly

[wetah]

The twenty_twenty_one_get_attachment_image_attributes function, added to the filter wp_get_attachment_image_attributes in inc/template-functions.php incorrectly checks the existence of some variables in this piece of code:

<?php
$meta = wp_get_attachment_metadata( $attachment->ID );
if ( $meta['width'] && $meta['height'] ) {
    $width  = (int) $meta['width'];
    $height = (int) $meta['height'];
}

This causes an Undefined index: width on line 460 error if the result from the function does not set any value to $meta. I believe something like this should be enough:

<?php
$meta = wp_get_attachment_metadata( $attachment->ID );
if ( isset($meta['width']) && isset($meta['height']) ) {
    $width  = (int) $meta['width'];
    $height = (int) $meta['height'];
}

[hasanuzzamanshamim]

Patch created for width & height validation

[mukesh27]

Thanks for the patch!

Mark as commit

[audrasjb]

Self-assigning for final review then commit consideration

[audrasjb]

In 52217:

Twenty Twenty-One: Prevent notice thrown in twenty_twenty_one_get_attachment_image_attributes().

Calling twenty_twenty_one_get_attachment_image_attributes() was causing an Undefined index: width|height notice to be thrown when the result from wp_get_attachment_metadata() does not set any value to $meta. This change adds an isset() check to prevent it.

Props wetah, hasanuzzamanshamim.
Fixes #54464.

[audrasjb]

#54526 was marked as a duplicate.

[SergeyBiryukov]

#54701 was marked as a duplicate.