#54487 closed task (blessed) (fixed)
Backport bug fixes from Gutenberg into Core for WP 5.9
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch has-unit-tests commit dev-reviewed |
Focuses: | Cc: |
Description
Every Monday ahead of Beta 1, Beta 2, etc. I will update @wordpress
packages to contain PRs marked for backport from Gutenberg into Core. This ticket tracks that work.
Change History (94)
This ticket was mentioned in PR #1928 on WordPress/wordpress-develop by noisysocks.
2 years ago
#1
- Keywords has-patch has-unit-tests added
noisysocks commented on PR #1928:
2 years ago
#2
I need to add https://github.com/WordPress/gutenberg/pull/36705 and https://github.com/WordPress/gutenberg/pull/36706 to this for the site editor to work properly.
This ticket was mentioned in PR #1967 on WordPress/wordpress-develop by noisysocks.
2 years ago
#4
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/36144
- https://github.com/WordPress/gutenberg/pull/36507
- https://github.com/WordPress/gutenberg/pull/36511
- https://github.com/WordPress/gutenberg/pull/36584
- https://github.com/WordPress/gutenberg/pull/36646
- https://github.com/WordPress/gutenberg/pull/36647
- https://github.com/WordPress/gutenberg/pull/36652
- https://github.com/WordPress/gutenberg/pull/36707
- https://github.com/WordPress/gutenberg/pull/36712
- https://github.com/WordPress/gutenberg/pull/36719
- https://github.com/WordPress/gutenberg/pull/36724
- https://github.com/WordPress/gutenberg/pull/36726
- https://github.com/WordPress/gutenberg/pull/36740
- https://github.com/WordPress/gutenberg/pull/36744
- https://github.com/WordPress/gutenberg/pull/36747
- https://github.com/WordPress/gutenberg/pull/36610
- https://github.com/WordPress/gutenberg/pull/36748
- https://github.com/WordPress/gutenberg/pull/36760
- https://github.com/WordPress/gutenberg/pull/36761
- https://github.com/WordPress/gutenberg/pull/36762
- https://github.com/WordPress/gutenberg/pull/36764
- https://github.com/WordPress/gutenberg/pull/36786
- https://github.com/WordPress/gutenberg/pull/36802
- https://github.com/WordPress/gutenberg/pull/36804
- https://github.com/WordPress/gutenberg/pull/36805
- https://github.com/WordPress/gutenberg/pull/36806
- https://github.com/WordPress/gutenberg/pull/36807
- https://github.com/WordPress/gutenberg/pull/36808
- https://github.com/WordPress/gutenberg/pull/36811
- https://github.com/WordPress/gutenberg/pull/36817
- https://github.com/WordPress/gutenberg/pull/36718
- https://github.com/WordPress/gutenberg/pull/36819
- https://github.com/WordPress/gutenberg/pull/36820
- https://github.com/WordPress/gutenberg/pull/36822
- https://github.com/WordPress/gutenberg/pull/36840
- https://github.com/WordPress/gutenberg/pull/36841
- https://github.com/WordPress/gutenberg/pull/36849
- https://github.com/WordPress/gutenberg/pull/36850
- https://github.com/WordPress/gutenberg/pull/36854
- https://github.com/WordPress/gutenberg/pull/36877
- https://github.com/WordPress/gutenberg/pull/36878
- https://github.com/WordPress/gutenberg/pull/36815
- https://github.com/WordPress/gutenberg/pull/36879
- https://github.com/WordPress/gutenberg/pull/36880
- https://github.com/WordPress/gutenberg/pull/36880
- https://github.com/WordPress/gutenberg/pull/36881
- https://github.com/WordPress/gutenberg/pull/36893
- https://github.com/WordPress/gutenberg/pull/36907
- https://github.com/WordPress/gutenberg/pull/36911
- https://github.com/WordPress/gutenberg/pull/36913
- https://github.com/WordPress/gutenberg/pull/36918
- https://github.com/WordPress/gutenberg/pull/36921
- https://github.com/WordPress/gutenberg/pull/36684
- https://github.com/WordPress/gutenberg/pull/36922
- https://github.com/WordPress/gutenberg/pull/36739
- https://github.com/WordPress/gutenberg/pull/36876
- https://github.com/WordPress/gutenberg/pull/36931
- https://github.com/WordPress/gutenberg/pull/36763
- https://github.com/WordPress/gutenberg/pull/36896
Trac ticket: https://core.trac.wordpress.org/ticket/54487
noisysocks commented on PR #1967:
2 years ago
#5
I've yet to test this. It's possible that some or all of these need to be committed first:
noisysocks commented on PR #1967:
2 years ago
#6
I've merged https://github.com/WordPress/wordpress-develop/pull/1937 into this branch.
noisysocks commented on PR #1967:
2 years ago
#7
@Mamaduka: Could you please fix the is_custom
PHP unit test failures here? I probably messed up porting the PHP changes in https://github.com/WordPress/gutenberg/pull/36911. It's confusing because Tests_REST_WpRestTemplatesController
seems to have some pretty significant differences between Core and the plugin.
@adamziel: Do you know why Tests_REST_WpRestTemplatesController::test_get_item_works_with_a_single_slash
fails here?
2 years ago
#8
@noisysocks we should probably sync Tests_REST_WpRestTemplatesController
tests back into plugin.
hellofromtonya commented on PR #1967:
2 years ago
#9
Noting this Trac ticket https://core.trac.wordpress.org/ticket/54532 and Gutenberg issue https://github.com/WordPress/gutenberg/issues/36962 for consideration _before_ Beta 1.
oandregal commented on PR #1928:
2 years ago
#10
Hey, we've missed some changes from https://github.com/WordPress/gutenberg/pull/36622 in this backport. I've prepared https://github.com/WordPress/wordpress-develop/pull/1971 to fix that.
oandregal commented on PR #1967:
2 years ago
#11
Robert, JFYI, in case is not merged by the time you read this. https://github.com/WordPress/wordpress-develop/pull/1971 would be nice to have for Beta 1 (Nov 30) as it fixes a bug with the last backports.
oandregal commented on PR #1967:
2 years ago
#12
Hi, looking at the class-theme-json.php
file I've found a thing to fix and a couple to improve. Apparently, I can't prepare a PR on top of this one, so I thought it'd be best in this case to share a patch to be applied by git apply <file.patch>
:
The contents of file.patch
are:
{{{patch
diff --git a/src/wp-includes/class-wp-theme-json.php b/src/wp-includes/class-wp-theme-json.php
index 4cdb44e457..635f670cff 100644
--- a/src/wp-includes/class-wp-theme-json.php
+++ b/src/wp-includes/class-wp-theme-json.php
@@ -75,17 +75,28 @@ class WP_Theme_JSON {
- This contains the necessary metadata to process them: *
- - path => where to find the preset within the settings section
-+ * - override => whether a theme preset with the same slug as a default preset
-+ * can override it
+ * - override => whether a theme preset with the same slug as a default preset
+ * can override it
- - value_key => the key that represents the value
- * - value_func => the callback to render the value (either value_key or value_func should be present)
+ * - value_func => optionally, instead of value_key, a function to generate
+ * the value that takes a preset as an argument
+ * (either value_key or value_func should be present)
- - css_vars => template string to use in generating the CSS Custom Property.
- Example output: "--wp--preset--duotone--blue: <value>" will generate as many CSS Custom Properties as presets defined
- substituting the $slug for the slug's value for each preset value.
- * - classes => array containing a structure with the classes to generate for the presets.
- * Each key is a template string to resolve similarly to the css_vars and each value is the CSS property to use for that class.
- * Example output: ".has-blue-color { color: <value> }"
- * - properties => a list of CSS properties to be used by kses to check the preset value is safe.
+ * - classes => array containing a structure with the classes to
+ * generate for the presets, where for each array item
+ * the key is the class name and the value the property name.
+ * The "$slug" substring will be replaced by the slug of each preset.
+ * For example:
+ * 'classes' => array(
+ * '.has-$slug-color' => 'color',
+ * '.has-$slug-background-color' => 'background-color',
+ * '.has-$slug-border-color' => 'border-color',
+ * )
+ * - properties => array of CSS properties to be used by kses to
+ * validate the content of each preset
+ * by means of the remove_insecure_properties method.
*
- @since 5.8.0
- @since 5.9.0 Added new presets and simplified the metadata structure.
@@ -305,6 +316,8 @@ class WP_Theme_JSON {
);
/
+ * The valid elements that can be found under styles.
+ *
- @since 5.8.0
- @var string[] */
@@ -479,6 +492,7 @@ class WP_Theme_JSON {
return $output;
}
+
/
- Returns the metadata for each block. *
}}}
oandregal commented on PR #1967:
2 years ago
#13
Got to review the class-wp-theme-json-resolver.php
class as well. I've only noticed minor changes to the comments:
{{{patch
diff --git a/src/wp-includes/class-wp-theme-json-resolver.php b/src/wp-includes/class-wp-theme-json-resolver.php
index 6a7e6a5bf9..659365b6ef 100644
--- a/src/wp-includes/class-wp-theme-json-resolver.php
+++ b/src/wp-includes/class-wp-theme-json-resolver.php
@@ -230,7 +230,6 @@ class WP_Theme_JSON_Resolver {
- @param array $post_status_filter Filter Optional. custom post type by
- post status. publish? by default,
- so it only fetches published posts.
- *
- @return array Custom Post Type for the user's origin config. */
@@ -333,8 +332,8 @@ class WP_Theme_JSON_Resolver {
/
- There are three sources of data (origins) for a site:
- * default, theme, and user. The user's has higher priority
- * than the theme's, and the theme's higher than core's.
+ * default, theme, and custom. The custom's has higher priority
+ * than the theme's, and the theme's higher than defaults's.
*
- Unlike the getters {@link get_core_data},
- {@link get_theme_data}, and {@link get_user_data},
}}}
I'm making some changes to the equivalent Gutenberg class to make the backports easier at https://github.com/WordPress/gutenberg/pull/36974
spacedmonkey commented on PR #1967:
2 years ago
#14
We need to ensure that https://github.com/WordPress/gutenberg/pull/36981 is merged and backported as well.
noisysocks commented on PR #1967:
2 years ago
#15
Thanks @oandregal for the review and fixes. I'm going to apply those patches and commit this patch, and _then_ follow up with a second commit to address https://github.com/WordPress/gutenberg/issues/36962 and https://github.com/WordPress/gutenberg/pull/36981. That way if I run into roadblocks we'll still have something in for beta 1 😀
hellofromtonya commented on PR #1967:
2 years ago
#16
@noisysocks need to make sure that the blocks/navigation-area
folder and file are also removed from Core on package update.
noisysocks commented on PR #1967:
2 years ago
#17
@noisysocks need to make sure that the
blocks/navigation-area
folder and file are also removed from Core on package update.
This patch doesn't modify navigation-area
. I've rebased this branch though so that that folder doesn't exist in this branch.
noisysocks commented on PR #1967:
2 years ago
#18
Gave this a smoke test locally and nothing seems amiss. Committing!
This ticket was mentioned in PR #1979 on WordPress/wordpress-develop by noisysocks.
2 years ago
#20
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/36432
- https://github.com/WordPress/gutenberg/pull/36734
- https://github.com/WordPress/gutenberg/pull/36753
- https://github.com/WordPress/gutenberg/pull/36759
- https://github.com/WordPress/gutenberg/pull/36920
- https://github.com/WordPress/gutenberg/pull/36933
- https://github.com/WordPress/gutenberg/pull/36945
- https://github.com/WordPress/gutenberg/pull/36948
- https://github.com/WordPress/gutenberg/pull/36954
- https://github.com/WordPress/gutenberg/pull/36959
- https://github.com/WordPress/gutenberg/pull/36963
- https://github.com/WordPress/gutenberg/pull/36968
- https://github.com/WordPress/gutenberg/pull/36981
Trac ticket: https://core.trac.wordpress.org/ticket/54487
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
noisysocks commented on PR #1928:
2 years ago
#23
Thanks @oandregal, good spotting!
This ticket was mentioned in PR #2012 on WordPress/wordpress-develop by noisysocks.
2 years ago
#24
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/36191
- https://github.com/WordPress/gutenberg/pull/36631
- https://github.com/WordPress/gutenberg/pull/36891
- https://github.com/WordPress/gutenberg/pull/36793
- https://github.com/WordPress/gutenberg/pull/36898
- https://github.com/WordPress/gutenberg/pull/36900
- https://github.com/WordPress/gutenberg/pull/36940
- https://github.com/WordPress/gutenberg/pull/36941
- https://github.com/WordPress/gutenberg/pull/36946
- https://github.com/WordPress/gutenberg/pull/36947
- https://github.com/WordPress/gutenberg/pull/36965
- https://github.com/WordPress/gutenberg/pull/36305
- https://github.com/WordPress/gutenberg/pull/36973
- https://github.com/WordPress/gutenberg/pull/36974
- https://github.com/WordPress/gutenberg/pull/36978
- https://github.com/WordPress/gutenberg/pull/36982
- https://github.com/WordPress/gutenberg/pull/36990
- https://github.com/WordPress/gutenberg/pull/36991
- https://github.com/WordPress/gutenberg/pull/36993
- https://github.com/WordPress/gutenberg/pull/36994
- https://github.com/WordPress/gutenberg/pull/37004
- https://github.com/WordPress/gutenberg/pull/37009
- https://github.com/WordPress/gutenberg/pull/37015
- https://github.com/WordPress/gutenberg/pull/37016
- https://github.com/WordPress/gutenberg/pull/37051
- https://github.com/WordPress/gutenberg/pull/37091
- https://github.com/WordPress/gutenberg/pull/37122
- https://github.com/WordPress/gutenberg/pull/36424
- https://github.com/WordPress/gutenberg/pull/36884
- https://github.com/WordPress/gutenberg/pull/37108
- https://github.com/WordPress/gutenberg/pull/36837
- https://github.com/WordPress/gutenberg/pull/36997
- https://github.com/WordPress/gutenberg/pull/36863
- https://github.com/WordPress/gutenberg/pull/37021
- https://github.com/WordPress/gutenberg/pull/37097
- https://github.com/WordPress/gutenberg/pull/37134
- https://github.com/WordPress/gutenberg/pull/37100
- https://github.com/WordPress/gutenberg/pull/36855
- https://github.com/WordPress/gutenberg/pull/36908
Trac ticket: https://core.trac.wordpress.org/ticket/54487
noisysocks commented on PR #2012:
2 years ago
#25
Tested this locally. Everything seems OK. I did notice one bug which I've created an issue for: https://github.com/WordPress/gutenberg/issues/37138
This ticket was mentioned in PR #2009 on WordPress/wordpress-develop by ocean90.
2 years ago
#27
Trac ticket: https://core.trac.wordpress.org/ticket/54487
See https://github.com/WordPress/gutenberg/pull/35975. This currently a bit blocked by https://github.com/WordPress/gutenberg/pull/37132
This ticket was mentioned in PR #2048 on WordPress/wordpress-develop by noisysocks.
2 years ago
#28
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/35787
- https://github.com/WordPress/gutenberg/pull/36000
- https://github.com/WordPress/gutenberg/pull/36455
- https://github.com/WordPress/gutenberg/pull/36488
- https://github.com/WordPress/gutenberg/pull/36720
- https://github.com/WordPress/gutenberg/pull/36851
- https://github.com/WordPress/gutenberg/pull/36950
- https://github.com/WordPress/gutenberg/pull/36960
- https://github.com/WordPress/gutenberg/pull/37008
- https://github.com/WordPress/gutenberg/pull/37062
- https://github.com/WordPress/gutenberg/pull/37074
- https://github.com/WordPress/gutenberg/pull/36925
- https://github.com/WordPress/gutenberg/pull/37115
- https://github.com/WordPress/gutenberg/pull/37131
- https://github.com/WordPress/gutenberg/pull/37132
- https://github.com/WordPress/gutenberg/pull/37135
- https://github.com/WordPress/gutenberg/pull/37137
- https://github.com/WordPress/gutenberg/pull/37141
- https://github.com/WordPress/gutenberg/pull/37142
- https://github.com/WordPress/gutenberg/pull/37149
- https://github.com/WordPress/gutenberg/pull/37161
- https://github.com/WordPress/gutenberg/pull/37176
- https://github.com/WordPress/gutenberg/pull/37180
- https://github.com/WordPress/gutenberg/pull/37186
- https://github.com/WordPress/gutenberg/pull/37187
- https://github.com/WordPress/gutenberg/pull/37210
- https://github.com/WordPress/gutenberg/pull/37212
- https://github.com/WordPress/gutenberg/pull/37213
- https://github.com/WordPress/gutenberg/pull/37215
- https://github.com/WordPress/gutenberg/pull/37218
- https://github.com/WordPress/gutenberg/pull/37219
- https://github.com/WordPress/gutenberg/pull/37226
- https://github.com/WordPress/gutenberg/pull/37235
- https://github.com/WordPress/gutenberg/pull/37238
- https://github.com/WordPress/gutenberg/pull/37244
- https://github.com/WordPress/gutenberg/pull/37245
- https://github.com/WordPress/gutenberg/pull/37249
- https://github.com/WordPress/gutenberg/pull/37253
- https://github.com/WordPress/gutenberg/pull/37254
- https://github.com/WordPress/gutenberg/pull/37257
- https://github.com/WordPress/gutenberg/pull/37270
- https://github.com/WordPress/gutenberg/pull/37271
- https://github.com/WordPress/gutenberg/pull/37282
- https://github.com/WordPress/gutenberg/pull/36842
- https://github.com/WordPress/gutenberg/pull/37296
- https://github.com/WordPress/gutenberg/pull/37184
Trac ticket: https://core.trac.wordpress.org/ticket/54487
noisysocks commented on PR #2048:
2 years ago
#29
@oandregal:
Could you please add in the PHP changes from these two PRs of yours to this branch? I am not too sure how to do it as things are a little different in Core.
- https://github.com/WordPress/gutenberg/pull/36851
- https://github.com/WordPress/gutenberg/pull/37296
Could you also please double check that I backported the PHP changes in these two PRs of yours properly?
- https://github.com/WordPress/gutenberg/pull/37008
- https://github.com/WordPress/gutenberg/pull/37254
@youknowriad:
Could you please check to see if I missed any backports from your recent PRs? It was a little difficult to spot changes amongst the refactoring that you were doing.
noisysocks commented on PR #2048:
2 years ago
#30
Will need to update packages with https://github.com/WordPress/gutenberg/pull/37315 to fix the test failures here. I can do that tomorrow.
2 years ago
#31
@noisysocks Are you okay when I merge the changes from https://github.com/WordPress/wordpress-develop/pull/2009 into this PR?
This was missed in an previous update and is related to https://github.com/WordPress/gutenberg/pull/37132.
youknowriad commented on PR #2048:
2 years ago
#32
@noisysocks I believe I've done all the necessary backports from these "sync", I left the labels there to sync with wp/trunk
branch 👍
oandregal commented on PR #2048:
2 years ago
#33
@noisysocks I've double-checked the PRs you mentioned and are backported fine!
As for the other two, pasting the patch below (to be applied by git apply <patch>
). I've tried to push to this PR but didn't have rights to do it, I presume it's because I'm not part of some WordPress GitHub group in this repo.
{{{patch
diff --git a/src/wp-includes/block-editor.php b/src/wp-includes/block-editor.php
index 7205ef2f4a..f175eff85d 100644
--- a/src/wp-includes/block-editor.php
+++ b/src/wp-includes/block-editor.php
@@ -311,7 +311,6 @@ function get_block_editor_settings( array $custom_settings, $block_editor_contex
array(
'css' => 'variables',
'unstableType' => 'presets',
- 'experimentalNoWrapper' => true,
),
array(
'css' => 'presets',
diff --git a/src/wp-includes/default-filters.php b/src/wp-includes/default-filters.php
index 39c7119fbc..fda548ed54 100644
--- a/src/wp-includes/default-filters.php
+++ b/src/wp-includes/default-filters.php
@@ -563,6 +563,7 @@ add_action( 'enqueue_block_editor_assets', 'wp_enqueue_registered_block_scripts_
add_action( 'enqueue_block_editor_assets', 'enqueue_editor_block_styles_assets' );
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_editor_block_directory_assets' );
add_action( 'enqueue_block_editor_assets', 'wp_enqueue_editor_format_library_assets' );
+add_action( 'enqueue_block_editor_assets', 'wp_enqueue_global_styles_css_custom_properties' );
add_action( 'admin_print_scripts-index.php', 'wp_localize_community_events' );
add_filter( 'wp_print_scripts', 'wp_just_in_time_script_localization' );
add_filter( 'print_scripts_array', 'wp_prototype_before_jquery' );
diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php
index 8313088e67..8384b6b2d8 100644
--- a/src/wp-includes/script-loader.php
+++ b/src/wp-includes/script-loader.php
@@ -2863,3 +2863,12 @@ function wp_add_iframed_editor_assets_html() {
echo "<script>window.editorAssets = $editor_assets</script>";
}
+
+/
+ * Function that enqueues the CSS Custom Properties coming from theme.json.
+ */
+function wp_enqueue_global_styles_css_custom_properties() {
+ wp_register_style( 'global-styles-css-custom-properties', false, array(), true, true );
+ wp_add_inline_style( 'global-styles-css-custom-properties', wp_get_global_stylesheet( array( 'variables' ) ) );
+ wp_enqueue_style( 'global-styles-css-custom-properties' );
+}
}}}
noisysocks commented on PR #2009:
2 years ago
#34
noisysocks commented on PR #2048:
2 years ago
#35
@noisysocks Are you okay when I merge the changes from #2009 into this PR?
This was missed in an previous update and is related to WordPress/gutenberg#37132.
Not a problem. I've merged your branch into my one.
@noisysocks I believe I've done all the necessary backports from these "sync" PRs, I left the labels there to sync with
wp/trunk
branch 👍
Thanks!
@noisysocks I've double-checked the PRs you mentioned and are backported fine!
As for the other two, pasting the patch below (to be applied by
git apply <patch>
) would do it. I've tried to push directly to this PR but I didn't have the right to do it. I presume it's because I'm not part of some WordPress GitHub group in this repo.
Thank you! I've applied the patch.
---
I'm just going to do another round of npm publishing so that we have https://github.com/WordPress/gutenberg/pull/37341 and https://github.com/WordPress/gutenberg/pull/37315. I see that @hellofromtonya fixed the failing test in 1272182 by updating the assertion but IMO the test failure was legitimate. https://github.com/WordPress/gutenberg/pull/37315 is the proper fix.
I'll commit when ready and when tests pass 🙂
noisysocks commented on PR #2048:
2 years ago
#37
Committed! Thanks everyone. https://core.trac.wordpress.org/changeset/52364
This ticket was mentioned in PR #2056 on WordPress/wordpress-develop by spacedmonkey.
2 years ago
#38
Trac ticket: https://core.trac.wordpress.org/ticket/54487
#39
@
2 years ago
- Keywords commit added
Marking PR 2056 for commit. It's a partial backport of wp_navigation
post type's capabilities from Gutenberg's PR 37454.
The remainder of the GB PR will be backported in a separate update.
This ticket was mentioned in PR #2073 on WordPress/wordpress-develop by tellthemachines.
2 years ago
#40
Trac ticket: https://core.trac.wordpress.org/ticket/54487
hellofromtonya commented on PR #2073:
2 years ago
#45
Committed via changeset https://core.trac.wordpress.org/changeset/52402.
This ticket was mentioned in PR #2110 on WordPress/wordpress-develop by noisysocks.
2 years ago
#47
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/35892
- https://github.com/WordPress/gutenberg/pull/37089
- https://github.com/WordPress/gutenberg/pull/37157
- https://github.com/WordPress/gutenberg/pull/37359
- https://github.com/WordPress/gutenberg/pull/37360
- https://github.com/WordPress/gutenberg/pull/37394
- https://github.com/WordPress/gutenberg/pull/37526
- https://github.com/WordPress/gutenberg/pull/37570
- https://github.com/WordPress/gutenberg/pull/37577
- https://github.com/WordPress/gutenberg/pull/37579
- https://github.com/WordPress/gutenberg/pull/37581
- https://github.com/WordPress/gutenberg/pull/37595
- https://github.com/WordPress/gutenberg/pull/37597
- https://github.com/WordPress/gutenberg/pull/37600
- https://github.com/WordPress/gutenberg/pull/37622
- https://github.com/WordPress/gutenberg/pull/37623
- https://github.com/WordPress/gutenberg/pull/37629
- https://github.com/WordPress/gutenberg/pull/37648
- https://github.com/WordPress/gutenberg/pull/37660
- https://github.com/WordPress/gutenberg/pull/36588
- https://github.com/WordPress/gutenberg/pull/37273
- https://github.com/WordPress/gutenberg/pull/36636
- https://github.com/WordPress/gutenberg/pull/37038
Trac ticket: https://core.trac.wordpress.org/ticket/54487
noisysocks commented on PR #2110:
2 years ago
#49
Committed in https://core.trac.wordpress.org/changeset/52434.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
#51
@
2 years ago
- Resolution set to fixed
- Status changed from assigned to closed
Closing this ticket as fixed for now. Let's reopen it for RC2 if needed :)
hellofromtonya commented on PR #2056:
23 months ago
#53
Thanks for the ping @getdave. Yes, this can be closed.
Committed via https://core.trac.wordpress.org/changeset/52400.
This ticket was mentioned in PR #2134 on WordPress/wordpress-develop by noisysocks.
23 months ago
#54
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/37553
- https://github.com/WordPress/gutenberg/pull/37665
- https://github.com/WordPress/gutenberg/pull/37672
- https://github.com/WordPress/gutenberg/pull/37696
- https://github.com/WordPress/gutenberg/pull/37711
- https://github.com/WordPress/gutenberg/pull/37718
- https://github.com/WordPress/gutenberg/pull/37733
- https://github.com/WordPress/gutenberg/pull/37741
- https://github.com/WordPress/gutenberg/pull/37777
- https://github.com/WordPress/gutenberg/pull/37791
- https://github.com/WordPress/gutenberg/pull/37812
- https://github.com/WordPress/gutenberg/pull/37819
- https://github.com/WordPress/gutenberg/pull/37829
Trac ticket: https://core.trac.wordpress.org/ticket/54487
#55
@
23 months ago
- Keywords commit dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
@hellofromTonya: https://github.com/WordPress/wordpress-develop/pull/2134 contains the backports ahead of RC 2. I've held off on committing as we need an additional review during the RC period. There are no manual PHP changes here—it's entirely auto-generated. If the patch doesn't apply cleanly because of conflicts feel free to re-generate using npm install && grunt build --dev
.
#56
@
23 months ago
- Keywords dev-reviewed added; dev-feedback removed
Thanks for reviewing @isabel_brison :)
#59
@
23 months ago
- Keywords commit dev-reviewed removed
- Resolution set to fixed
- Status changed from reopened to closed
This ticket was mentioned in PR #2184 on WordPress/wordpress-develop by noisysocks.
23 months ago
#60
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/30557
- https://github.com/WordPress/gutenberg/pull/36571
- https://github.com/WordPress/gutenberg/pull/37545
- https://github.com/WordPress/gutenberg/pull/37813
- https://github.com/WordPress/gutenberg/pull/37842
- https://github.com/WordPress/gutenberg/pull/37843
- https://github.com/WordPress/gutenberg/pull/37848
- https://github.com/WordPress/gutenberg/pull/37849
- https://github.com/WordPress/gutenberg/pull/37872
- https://github.com/WordPress/gutenberg/pull/37937
- https://github.com/WordPress/gutenberg/pull/37939
- https://github.com/WordPress/gutenberg/pull/37963
- https://github.com/WordPress/gutenberg/pull/38017
- https://github.com/WordPress/gutenberg/pull/38019
Trac ticket: https://core.trac.wordpress.org/ticket/54487
#61
@
23 months ago
- Keywords i18n-change commit dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
https://github.com/WordPress/wordpress-develop/pull/2184 contains the backports for RC 4. Note that https://github.com/WordPress/gutenberg/pull/37939 contained some minor string changes (adding context) that I believe were requested from the i18n team.
noisysocks commented on PR #2184:
23 months ago
#62
Thanks for testing! If I follow the steps in https://github.com/WordPress/gutenberg/issues/37708 I can't repro the issue. I also don't see overflow: hidden
on my .edit-site-visual-editor
when I look in DevTools which indicates to me that https://github.com/WordPress/gutenberg/pull/38019 is in there. Are you sure you ran grunt build
before testing?
#63
@
23 months ago
- Keywords dev-reviewed added; dev-feedback removed
Thanks for reviewing @isabel_brison!
#66
@
23 months ago
- Keywords commit dev-reviewed removed
- Resolution set to fixed
- Status changed from reopened to closed
This ticket was mentioned in PR #2188 on WordPress/wordpress-develop by hellofromtonya.
23 months ago
#67
Backporting https://github.com/WordPress/gutenberg/pull/38032 which fixes nav block's menu close button not working on mobile issue.
Trac ticket: https://core.trac.wordpress.org/ticket/54487
#68
@
23 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport navigation block's fix for menu close button not working on mobile https://github.com/WordPress/gutenberg/issues/37996.
#69
@
23 months ago
- Keywords commit added
https://github.com/WordPress/wordpress-develop/pull/2188 is approved. Marking for commit to trunk
.
#71
@
23 months ago
- Keywords dev-feedback added
Marking dev-feedback
for 2nd committer to review for backport to 5.9 branch.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
23 months ago
#73
@
23 months ago
- Keywords dev-reviewed added; dev-feedback removed
[52598] looks good to backport.
hellofromtonya commented on PR #2188:
23 months ago
#75
Committed via https://core.trac.wordpress.org/changeset/52598.
This ticket was mentioned in PR #2220 on WordPress/wordpress-develop by noisysocks.
22 months ago
#77
Update packages to include these bug fixes from Gutenberg:
- https://github.com/WordPress/gutenberg/pull/36887
- https://github.com/WordPress/gutenberg/pull/38093
- https://github.com/WordPress/gutenberg/pull/38123
- https://github.com/WordPress/gutenberg/pull/38168
Trac ticket: https://core.trac.wordpress.org/ticket/54487
#78
@
22 months ago
- Keywords i18n-change commit dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
https://github.com/WordPress/wordpress-develop/pull/2220 contains the backports for our unplanned RC 4 release.
noisysocks commented on PR #2220:
22 months ago
#80
Thank you @talldan! Create an issue and I'll note it as "good to fix in RC 4 if we can, but not a blocker" along with https://github.com/WordPress/gutenberg/issues/34729.
22 months ago
#82
Here's an issue: https://github.com/WordPress/gutenberg/issues/38172
noisysocks commented on PR #2220:
22 months ago
#86
This ticket was mentioned in PR #2222 on WordPress/wordpress-develop by desrosj.
22 months ago
#87
#88
@
22 months ago
- Keywords dev-feedback added; dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport https://github.com/WordPress/wordpress-develop/pull/2222 for 5.9 RC4.
hellofromtonya commented on PR #2222:
22 months ago
#89
I was little too quick on the approval 🤦♀️ The script loader file needs to be regenerated.
#91
@
22 months ago
- Keywords dev-feedback removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backport.
Update packages to include these bug fixes from Gutenberg:
Trac ticket: https://core.trac.wordpress.org/ticket/54487