Opened 3 years ago
Closed 3 years ago
#54491 closed defect (bug) (fixed)
Site Editor: Move the link color styles to the footer
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch |
Focuses: | Cc: |
Description
The fix in https://github.com/WordPress/gutenberg/pull/35425 has seemingly not properly been backported into Core. Let's make sure that the changes in that PR are in Core.
Step-by-step reproduction instructions:
- Try using 2022 theme
- Notice the header doesn't have an extra margin at the top on Gutenberg but does so with just WP trunk.
First reported in https://github.com/WordPress/gutenberg/issues/36743.
Change History (5)
#2
@
3 years ago
I still see the issue with the padding in the frontend of 2022, that said, while the symptoms are similar, I think the issue is another missed backport: the skip link position and not the link color ones. I'll work on that asap.
#3
@
3 years ago
We need to backport this PR basically https://github.com/WordPress/gutenberg/pull/34986
This ticket was mentioned in PR #1939 on WordPress/wordpress-develop by youknowriad.
3 years ago
#4
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/54491
This PR backports the following Gutenberg PR into Core https://github.com/WordPress/gutenberg/pull/34986
Hi @youknowriad. The changes in https://github.com/WordPress/gutenberg/pull/35425 already exist in Core:
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/block-supports/elements.php#L71-L81
I'm not able to see any extra padding at the top of the Header when using Twenty Twenty-two, but admittedly I'm not 100% sure what I'm looking for. Could you please double check?