Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #54504, comment 36


Ignore:
Timestamp:
12/07/2021 12:29:59 AM (2 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54504, comment 36

    v2 v3  
    88> Am I surprised that that breaks things ? No, as that's a very clear bug and code smell. But it's a bug in the upgrader, not in Requests.
    99
    10 I understand that, but on the other hand files in WordPress should never be renamed unless absolutely unavoidable. If this triggers a but in WP is there a 100% guarantee it will never trigger a bug somewhere else?
     10I understand that, but on the other hand files in WordPress should never be renamed unless absolutely unavoidable. If this triggers a bug in WP is there a 100% guarantee it will never trigger a bug somewhere else?
    1111
    1212As this is a WordPress (sub) project, I'd think it should follow the established rules/best practices. So the questing is: is this completely unavoidable? If not, I stand by my recommendation to revert and release a new version before updating it in WP.