Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #54504, comment 82


Ignore:
Timestamp:
11/24/2022 01:51:49 AM (15 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54504, comment 82

    v1 v2  
    1212> Requests is still an EXTERNAL dependency.
    1313
    14 I think this is the big misconception here. Requests used to be an external dependency before it was moved from rmccue/Requests to WordPress/Requests. After moving there it became an internal dependency/library. In effect the WordPress project "forked" the Requests library to ensure it is maintained.
     14I think this is the big misconception here. Requests used to be an external dependency before it was moved from rmccue/Requests to WordPress/Requests. After moving there it became an internal dependency/library. In effect the WordPress project "forked" the Requests library to ensure it is maintained (if I remember right).
    1515
    1616This actually brings another question: why does the Requests library use `WpOrg\` namespace? As @dd32 [https://core.trac.wordpress.org/ticket/54504#comment:8 above] I'm a bit unsure if that's the best choice. Of course, as a project under the WordPress umbrella it can use any form of the WordPress name, but perhaps may be better to use `Requests\`, similarly to other PHP libraries? Any other opinions on that?