WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#54509 closed defect (bug) (fixed)

Attachment edit view details information formatting/styling inconsistency

Reported by: szaqal21's profile szaqal21 Owned by: joedolson's profile joedolson
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch commit
Focuses: ui Cc:

Description (last modified by sabernhardt)

There is some inconsistency in attachment edit view (list and grid style view). In classic edit view (post.php?post=XXX&action=edit) "Original image" link isn't wrapped in <strong> but "Uploaded by" link is. And in edit view of grid style view (dialog) "Original image" label isn't wrapped in <strong> like other labels are.

Attachments (8)

attachment-edit-view.jpg​ (183.2 KB) - added by szaqal21 3 years ago.
Original image link not wrapped in <strong>
attachment-edit-view-2.jpg​ (118.8 KB) - added by szaqal21 3 years ago.
Dialog view, Original image label not wrapped in <strong> like other labels.
insert-media-into-post.png​ (138.4 KB) - added by sabernhardt 2 years ago.
dialog for inserting an image into a post (which does not seem to need a strong tag)
54509.diff​ (1.2 KB) - added by sabernhardt 2 years ago.
adding strong tags to Attachment details dialog and Edit Media page
Attachment-details-dialog-with-patch.png​ (149.8 KB) - added by sabernhardt 2 years ago.
Edit-Media-with-patch.png​ (12.1 KB) - added by sabernhardt 2 years ago.
54509.2.diff​ (1.2 KB) - added by sabernhardt 2 years ago.
moves strong tag inside link on Edit Media page
Edit-Media-with-patch-54509.2.png​ (12.2 KB) - added by sabernhardt 2 years ago.

Download all attachments as: .zip

Change History (20)

@szaqal21
3 years ago

Original image link not wrapped in <strong>

@szaqal21
3 years ago

Dialog view, Original image label not wrapped in <strong> like other labels.

#1 @audrasjb
3 years ago

  • Keywords needs-screenshots needs-patch added
  • Version 5.8.2 deleted

#2 @audrasjb
3 years ago

  • Keywords has-screenshots added; needs-screenshots removed

@sabernhardt
2 years ago

dialog for inserting an image into a post (which does not seem to need a strong tag)

#3 @sabernhardt
2 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 6.2

Thanks for the report! These should be (more) consistent.

Last edited 2 years ago by sabernhardt (previous) (diff)

@sabernhardt
2 years ago

adding strong tags to Attachment details dialog and Edit Media page

@sabernhardt
2 years ago

@sabernhardt
2 years ago

#4 @sabernhardt
2 years ago

  • Keywords has-patch added; needs-patch removed

@sabernhardt
2 years ago

moves strong tag inside link on Edit Media page

@sabernhardt
2 years ago

#5 @sabernhardt
2 years ago

The strong tag is inside the "Uploaded by" link, so the patch is updated to do the same for the new tag inside the "Original image" link.

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs.
2 years ago

#7 @joedolson
2 years ago

  • Owner set to joedolson
  • Status changed from new to reviewing

This ticket was mentioned in ​PR #3960 on ​WordPress/wordpress-develop by ​@joedolson.
2 years ago #8

Make links and labels consistent on media attachment screens

Trac ticket: https://core.trac.wordpress.org/ticket/54509

#9 @joedolson
2 years ago

  • Keywords commit added

#10 @joedolson
2 years ago

  • Status changed from reviewing to accepted

#11 @joedolson
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55187:

Media: Fix inconsistent font weight in media detail views.

Make font weight consistent between different screens and different parts of media views.

Props szaqal21, sabernhardt.
Fixes #54509.

​@joedolson commented on ​PR #3960:
2 years ago #12

Fixed in r55187

Note: See TracTickets for help on using tickets.