Remove cache time limitation in WP_Term_Query

[spacedmonkey]

Currently there is a limitation, that term caches found in WP_Term_Query will only last one day. See the following snippet.

wp_cache_add( $cache_key, $terms, 'terms', DAY_IN_SECONDS );

If we can ensure that cache invalidation is happening correctly, this limitation can be removed. Once this limitation is removed, cache will live until their are correctly invalidation.

[flixos90]

I don't recall why this was introduced. Maybe there are some limitations in the current cache invalidation for term queries, and this was implemented to more or less cater for that. Or it could have been to not pollute the object cache, since those term query hashes used for cache keys can frequently change.

Anyway, since this isn't present in other object type query implementations, at a high level I agree this should be removed at some point. However, we should make sure it isn't indeed there for a reason where removing it could result in a regression.

[dlh]

If you'll forgive me, I would be very appreciative if the enhancement proposed in #52710 could be considered alongside this one.

[tillkruess]

I can see the original argument for filling up the cache unnecessarily, but not for invalidation purposes.

+1

Trac ticket: https://core.trac.wordpress.org/ticket/54511

[spacedmonkey]

I have created a patch at ​#2162, ready for review.

Trac ticket: https://core.trac.wordpress.org/ticket/54511

Closed in favour ​https://github.com/WordPress/wordpress-develop/pull/2196

[adamsilverstein]

Originally added in https://core.trac.wordpress.org/ticket/35381 - where the day cache was also questioned at the time. Based on the response, the reasons for keeping it seemed week and open for reconsideration. +1 to removing and writing a dev note explaining why.

cc: @boonebgorges hi friend, we are touching your code, feedback welcome!

[boonebgorges]

Thanks for the ping!

Looking back at https://core.trac.wordpress.org/ticket/35381#comment:13, I see that we simply inherited this TTL strategy from [15583]. As such, I'm +1 for the change proposed here.

[spacedmonkey]

@boonebgorges @adamsilverstein

Are you happy for me to commit this change then?

[spacedmonkey]

@boonebgorges @adamsilverstein

Are you happy for me to commit this change then?

[adamsilverstein]

Replying to spacedmonkey:

@boonebgorges @adamsilverstein

Are you happy for me to commit this change then?

yes, +1 go for it!

[spacedmonkey]

In 52669:

Taxonomy: Remove cache expiry limitation in WP_Term_Query.

Remove the one day expiry limitation from query caches found in the WP_Term_Qurery class. Removing this limitation means that the caches will remain in object caching, as long as possible. Ensure that all term / taxonomy cache clear functions invalidate query caches, by deleting the last_changed value in the terms cache group.

Props spacedmonkey, adamsilverstein, boonebgorges, tillkruess, dlh, flixos90.
Fixes #54511.

[spacedmonkey]

Dev note ready for ​review.

[spacedmonkey]

Has dev note - ​https://make.wordpress.org/core/2022/04/28/taxonomy-performance-improvements-in-wordpress-6-0/