Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54528 closed defect (bug) (fixed)

Tests: Disable PHP version check until PHP 8.0 compatibility is achieved.

Reported by: costdev's profile costdev Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Build/Test Tools Keywords: has-patch 2nd-opinion
Focuses: Cc:


If no discussions or decisions have been made on this yet, I suggest that we disable the failing assertion in this test method until we either:

  • Reach PHP 8.0 compatibility and bump the recommended PHP version in src/readme.html.
  • Refactor this part of the test method.
  • Make another decision about this.

Attachments (1)

54528.diff (939 bytes) - added by costdev 2 years ago.
Disables the failing assertion.

Download all attachments as: .zip

Change History (3)

2 years ago

Disables the failing assertion.

#1 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 5.9

Thanks for the ticket and patch.
Indeed, we need to disable that unit test otherwise it will throw errors on each commit.

#2 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 52260:

Tests: Temporarily disable the check that the current recommended PHP version is actively supported.

As PHP 7.4 moved from active support to security support until 28 Nov 2022, and no discussions or decisions have been made yet on bumping the recommended version to PHP 8.0, this commit disables the failing assertion for now.

This should be revisited once WordPress achieves PHP 8.0 compatibility and the recommended PHP version in readme.html can be bumped, or another decision is made about this.

Follow-up to [26166], [33937], [33944], [33946], [35172], [39582], [39583], [40241], [46682], [46996], [46998].

Props costdev, audrasjb.
Fixes #54528.

Note: See TracTickets for help on using tickets.