WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#54535 closed defect (bug) (fixed)

Make first comment URLs translatable

Reported by: desrosj Owned by: SergeyBiryukov
Priority: normal Milestone: 6.0
Component: Upgrade/Install Version:
Severity: normal Keywords: good-first-bug has-patch
Cc: Focuses:

Description

When English is not the site's default language, using https://wordpress.org/ and https://gravatar.com as the default comment URL may not be ideal.

Wrapping these strings in translation functions will allow the URL to be localized.

I leaned towards just using the default Gravatar URL, but it looks like the English URL has been used elsewhere in Core when wrapped in __() (source). I think the same pattern could be used here.

Change History (6)

This ticket was mentioned in ​PR #1974 on ​WordPress/wordpress-develop by ​kebbet.
5 years ago #1

  • Keywords has-patch added; needs-patch removed

Something like this?

Trac ticket: https://core.trac.wordpress.org/ticket/54535

This ticket was mentioned in ​PR #1974 on ​WordPress/wordpress-develop by ​kebbet.
5 years ago #2

Something like this?

Trac ticket: https://core.trac.wordpress.org/ticket/54535

#3 @kebbet
5 years ago

Maybe a candidate for 6.0? Pinging component maintainers @audrasjb @desrosj

#4 @SergeyBiryukov
5 years ago

  • Milestone Future Release → 6.0

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 52451:

Upgrade/Install: Make first comment URLs translatable.

This allows translators to localize the https://wordpress.org/ and https://gravatar.com/ URLs in the first comment on a new installation.

Follow-up to [2409], [37888], [37921].

Props kebbet, desrosj.
Fixes #54535.

Note: See TracTickets for help on using tickets.