#54535 closed defect (bug) (fixed)
Make first comment URLs translatable
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | good-first-bug has-patch |
Focuses: | Cc: |
Description
When English is not the site's default language, using https://wordpress.org/
and https://gravatar.com
as the default comment URL may not be ideal.
Wrapping these strings in translation functions will allow the URL to be localized.
I leaned towards just using the default Gravatar URL, but it looks like the English URL has been used elsewhere in Core when wrapped in __()
(source). I think the same pattern could be used here.
Change History (6)
This ticket was mentioned in PR #1974 on WordPress/wordpress-develop by kebbet.
18 months ago
#1
- Keywords has-patch added; needs-patch removed
This ticket was mentioned in PR #1974 on WordPress/wordpress-develop by kebbet.
18 months ago
#2
Something like this?
Trac ticket: https://core.trac.wordpress.org/ticket/54535
#5
@
17 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 52451:
SergeyBiryukov commented on PR #1974:
17 months ago
#6
Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/52451.
Something like this?
Trac ticket: https://core.trac.wordpress.org/ticket/54535