#54536 closed defect (bug) (fixed)
Use rest_get_route_for_taxonomy_items and rest_get_route_for_post_type_items functions in full edit editting
Reported by: | spacedmonkey | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | REST API | Keywords: | has-patch commit |
Focuses: | rest-api | Cc: |
Description
In 51962 and 51964 new functions rest_get_route_for_post_type_items
and rest_get_route_for_taxonomy_items
were added. These functions are now used in all parts of core that reference taxonomy and post type rest controller endpoints. However, references to wp/v2/posts are hardcoded in full site editing screen.
Change History (14)
This ticket was mentioned in PR #1977 on WordPress/wordpress-develop by spacedmonkey.
3 years ago
#1
- Keywords has-patch added; needs-patch removed
#3
@
3 years ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from new to closed
In 52276:
#4
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
The above commit had the wrong ticket annotation, sorry, reopening.
#5
@
3 years ago
- Owner changed from peterwilsoncc to hellofromTonya
- Status changed from reopened to reviewing
Assigning to me for commit.
hellofromtonya commented on PR #1977:
3 years ago
#7
Committed via https://core.trac.wordpress.org/changeset/52281.
This ticket was mentioned in PR #1986 on WordPress/wordpress-develop by walbo.
3 years ago
#8
Trac ticket: https://core.trac.wordpress.org/ticket/54536
#9
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Getting a notice on the site-editor page after this was merged yesterday.
The rest_get_route_for_post_type_items
excepts the post type name and not the post type object.
#10
@
3 years ago
- Keywords has-patch commit removed
Resetting keywords, which were for the previous commit.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
#12
@
3 years ago
- Keywords has-patch commit added
Thanks @walbo for catching that bug. You're right. It accepts a string, not object.
Marking your patch for commit.
hellofromtonya commented on PR #1986:
3 years ago
#14
Committed via changeset https://core.trac.wordpress.org/changeset/52333.
…y_items function in all site editing.
Trac ticket: https://core.trac.wordpress.org/ticket/54536