Make WordPress Core

Opened 4 years ago

Closed 7 months ago

Last modified 7 months ago

#54540 closed enhancement (worksforme)

Need to Add any Icon or align text at the center of social icon block in inspector style setting of Twenty twenty one theme

Reported by: multidots1896's profile multidots1896 Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.8.2
Component: Editor Keywords: has-screenshots
Focuses: Cc:

Description

Need to Add any Icon or align text at the center of social icon block in inspector style setting of Twenty twenty one theme
screenshot:https://prnt.sc/213h9ds
Because while selecting icon style setting box layout not looks proper and shows empty box.
We have to adding icon for indication on selecting box. or we have to align box styling text between the box.
screenshot:

Attachments (7)

screenshot.png (71.2 KB) - added by multidots1896 4 years ago.
Modify style layout of social icon block
screenshot.2.png (71.2 KB) - added by multidots1896 4 years ago.
attached screenshot of ticket
social-icons-preview-WP5.8.png (25.8 KB) - added by sabernhardt 4 years ago.
previews showing with WordPress 5.8.2
social-icons-preview-WP5.9-Beta2.png (25.7 KB) - added by sabernhardt 4 years ago.
previews showing with WordPress 5.9 Beta 2
Screenshot 2021-12-10 at 14-23-45 Edit Page ‹ wpcontribution — WordPress.png (43.9 KB) - added by multidots1896 4 years ago.
firefox 95.0 browser preview
social-block-preview.png (32.5 KB) - added by sabernhardt 7 months ago.
Previews in WordPress 6.9 trunk
social-icons-TT1-default.png (42.2 KB) - added by sabernhardt 7 months ago.
Default style with Twenty Twenty-One in WordPress 6.9 trunk

Download all attachments as: .zip

Change History (18)

#1 @multidots1896
4 years ago

  • Keywords needs-patch added
  • Type changed from defect (bug) to enhancement
  • Version set to 5.8.2

#2 in reply to: ↑ description @multidots1896
4 years ago

Added screenshot for proper view of social Icon style box.
screenshot:https://prnt.sc/213iazt

@multidots1896
4 years ago

Modify style layout of social icon block

#3 @multidots1896
4 years ago

  • Keywords needs-design-feedback has-screenshots added; needs-patch removed

#4 follow-up: @sabernhardt
4 years ago

  • Component changed from General to Editor

Thanks for the report!

Do you have iframes blocked/turned off?

I'm able to see the iframe previews when editing a post or a widget (with either Twenty Twenty or Twenty Twenty-One). If possible, however, I would prefer only one icon against the background color instead of a collection of three small icons.

Also, could you attach any screenshots to the ticket? The Lightshot site keeps making me prove I'm human and then it still doesn't show the image.

@multidots1896
4 years ago

attached screenshot of ticket

#5 in reply to: ↑ 4 @multidots1896
4 years ago

Replying to sabernhardt:

thanks for comment.

can you please check latest attached screenshot of ticket.

#6 follow-up: @sabernhardt
4 years ago

I was wrong about the iframes: the preview that should be visible is not inside one of those tags.

I still don't know why the preview does not show for you, though.

#7 in reply to: ↑ 6 @multidots1896
4 years ago

Replying to sabernhardt:

which wordpress version you are using.can you please send the screenshot of your screen

@sabernhardt
4 years ago

previews showing with WordPress 5.8.2

@sabernhardt
4 years ago

previews showing with WordPress 5.9 Beta 2

#8 follow-up: @sabernhardt
4 years ago

Those screenshots are from local installations, using Firefox 94.0.2 and Windows 10.

#9 in reply to: ↑ 8 @multidots1896
4 years ago

Replying to sabernhardt:
I think here is problem of browser issue because same preview are showing in my firefox 95.0 and windows 10.
but does not showing in google chrome browser.

@sabernhardt
7 months ago

Previews in WordPress 6.9 trunk

#10 @sabernhardt
7 months ago

  • Keywords needs-design-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

The previews appear on hover or focus now, with the style name clearly visible in the control. I think this is good enough.

If you still experience a problem with the block interface, or find a way to improve it, you could discuss that on the Gutenberg repository.
https://github.com/WordPress/gutenberg/issues

@sabernhardt
7 months ago

Default style with Twenty Twenty-One in WordPress 6.9 trunk

#11 @sabernhardt
7 months ago

The sidebar control issue did not relate to the theme, but showing it in Twenty Twenty-One is still important :)

Note: See TracTickets for help on using tickets.