![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#54551 closed task (blessed) (fixed)
Block Template Utils: Enable currently incomplete unit test
| Reported by: | Bernhard Reiter | Owned by: | hellofromTonya |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.9 |
| Component: | Editor | Version: | 5.9 |
| Severity: | normal | Keywords: | has-patch has-unit-tests commit |
| Cc: | Focuses: |
Description
We currently have one Block Template Utils unit test marked as incomplete, as it needs a block template theme, which at the time the test was backported from Gutenberg wasn't yet available.
We should enable it now that we have both Twenty Twenty Two and the block-theme and block-theme-child test fixture block template themes are available.
Change History (8)
This ticket was mentioned in PR #1990 on WordPress/wordpress-develop by ockham.
5 years ago
#1
- Keywords has-patch has-unit-tests added
5 years ago
#3
Ah, tests need some more tweaking, probably akin to https://github.com/WordPress/wordpress-develop/pull/1920.
#5
@
5 years ago
- Keywords commit added
https://github.com/WordPress/wordpress-develop/pull/1990 looks good to me. Thanks @bernhard-reiter!
#6
@
5 years ago
- Owner set to
- Status new → reviewing
Self-assigning for commit, I already reviewed it.
hellofromtonya commented on PR #1990:
5 years ago
#8
Committed via https://core.trac.wordpress.org/changeset/52314.
We currently have one Block Template Utils unit test marked as incomplete, as it needs a block template theme, which at the time the test was backported from Gutenberg wasn't yet available.
We should enable it now that we have both Twenty Twenty Two and the
block-themeandblock-theme-childtest fixture block template themes are available.Trac ticket: https://core.trac.wordpress.org/ticket/54551