Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54583 closed defect (bug) (fixed)

Add `__unstableGalleryWithImageBlocks` block editor setting for 5.9 release

Reported by: glendaviesnz's profile glendaviesnz Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

Currently the mobile apps rely on the __unstableGalleryWithImageBlocks flag being set here in order to enable the new gallery block format.

Because the core release doesn't include the gutenberg_experiments_editor_settings method, this value could be hard coded get_default_block_editor_settings method in order to ensure that versions of the mobile app >= 18.2 will be able to add and edit gallery blocks in the new format.

Change History (11)

#1 @noisysocks
3 years ago

  • Component changed from General to Editor
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.9
  • Type changed from feature request to defect (bug)

This ticket was mentioned in PR #2011 on WordPress/wordpress-develop by glendaviesnz.


3 years ago
#2

  • Keywords has-patch added; needs-patch removed

#3 @glendaviesnz
3 years ago

This should be tested against a copy of the mobile app >= 18.2 as this setting only affects the mobile apps. I will try and get this testing done today.

#4 @costdev
3 years ago

  • Keywords needs-testing added

glendaviesnz commented on PR #2011:


3 years ago
#5

The test needs an update for the new size.

Done.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

#7 @glendaviesnz
3 years ago

I have tested the attached PR with WP 5.9 Beta 2 and the mobile app 18.7 on android. I was able to view and edit a new format Gallery block that was added on web in the mobile app, and also a new gallery block added on mobile was in the new format. This shows that this patch is working as expected as the mobile app won't add Gallery blocks in the new format unless the __unstableGalleryWithImageBlocks editor setting is true

This ticket was mentioned in Slack in #core by glendaviesnz. View the logs.


3 years ago

#9 @hellofromTonya
3 years ago

  • Keywords commit added; needs-testing removed

Thank you @glendaviesnz for the patch and validating (testing) it works expected on the mobile app.

PR 2011 is ready for commit.

#10 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 52349:

Editor: Add an editor settings flag to enable the new gallery for mobile apps for 5.9.

Currently the WordPress mobile apps rely on the __unstableGalleryWithImageBlocks flag being set in order to enable the new gallery block format.

This commit includes the value in the get_default_block_editor_settings() function in order to ensure that versions of the mobile app >= 18.2 will be able to add and edit gallery blocks in the new format.

Props glendaviesnz, ocean90, hellofromTonya, noisysocks.
Fixes #54583.

Note: See TracTickets for help on using tickets.