WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54611 closed defect (bug) (fixed)

Missing context on Full Site Editing new post types translatable strings

Reported by: audrasjb's profile audrasjb Owned by: audrasjb's profile audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Posts, Post Types Keywords: has-patch commit
Focuses: Cc:

Description (last modified by audrasjb)

The following bundled post types were added to handle Full Site Editing features:

  • wp_template
  • wp_template_part
  • wp_global_styles
  • wp_navigation

Except for the silent wp_global_styles, they are all missing contextualization on the name and singular_name labels.

Change History (9)

#1 @audrasjb
3 years ago

  • Component changed from Editor to Posts, Post Types

This ticket was mentioned in ​PR #2044 on ​WordPress/wordpress-develop by ​audrasjb.
3 years ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54611

#3 @audrasjb
3 years ago

  • Description modified (diff)

#4 @audrasjb
3 years ago

  • Summary changed from Missing context to Full Site Editing new post types translatable strings to Missing context on Full Site Editing new post types translatable strings

#5 @audrasjb
3 years ago

  • Keywords 2nd-opinion added

We don't have any maintainer for the Post, Post Types component, so let's ping @SergeyBiryukov for a quick review concerning i18n consistency :)

Marking this as waiting for 2nd-opinion.

#6 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to assigned

#7 @hellofromTonya
3 years ago

  • Keywords commit added; 2nd-opinion removed

​PR 2044 is consistent with other post types. Also confirmed the next update which removes the Nav menu item does not conflict with this PR.

Marking it for commit.

#8 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52368:

Posts, Post Types: Add missing translation context on FSE related post types labels.

This makes it easier for translators to identify the context of each label. This change also brings consistency with other built-in post types.

Follow-up to [52145], [52069], [52062], [52041], [51003].

Props audrasjb, hellofromTonya.
Fixes #54611.

Note: See TracTickets for help on using tickets.