Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54618 closed defect (bug) (reported-upstream)

Pattern Previews are not displaying correctly in Pattern Explorer in 5.9 Beta 2

Reported by: ndiego's profile ndiego Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

Was testing the latest version of Twenty Twenty-Two with 5.9 Beta 2. The pattern previews in the Pattern Explorer appear "off", many are too tall and are not rendering properly. Enabling the latest version of Gutenberg seems to resolve the issue. This leads me to believe "something" was not properly ported into 5.9 from Gutenberg.

Example in 5.9 Beta 2 (incorrect): https://drive.google.com/open?id=10htcieocEkKz_b0KETDNlIdJt0_1yhOp

Example in 5.9 Beta 2 with Gutenberg active (correct): https://drive.google.com/open?id=10iuzW9gVy1tg7zGQ0xJ4SkAJ9NmUl_5M

Tested in latest version of Chrome, WordPress 5.9 Beta 2, and Gutenberg 12.1.0.

Attachments (2)

Pattern previews in explorer - Correct.png (618.9 KB) - added by hellofromTonya 3 years ago.
Pattern preview with Gutenberg active (correct)
Pattern previews in explorer - Incorrect.png (215.1 KB) - added by hellofromTonya 3 years ago.
Pattern preview without Gutenberg active (incorrect)

Download all attachments as: .zip

Change History (6)

@hellofromTonya
3 years ago

Pattern preview with Gutenberg active (correct)

@hellofromTonya
3 years ago

Pattern preview without Gutenberg active (incorrect)

#1 @hellofromTonya
3 years ago

  • Component changed from General to Editor
  • Milestone changed from Awaiting Review to 5.9

Hello @ndiego,

Welcome back to WordPress Core's Trac! Thank you for the feedback :)

Pulling this ticket into 5.9 for investigation.

Hey @noisysocks, any idea if this is in the new backports?

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 years ago

#3 @hellofromTonya
3 years ago

  • Milestone 5.9 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Appears this issue was fixed in Gutenberg https://github.com/WordPress/gutenberg/pull/37296 and backported with the latest fixes earlier today.

I'll close this ticket at fixed. But @ndiego can you retest to verify with trunk or when Beta 3 is released to ensure it is fixed. If no, please report upstream in Gutenberg repository.

#4 @ndiego
3 years ago

Great, thanks! I'll test later today.

Note: See TracTickets for help on using tickets.