Context Navigation

← Previous Ticket
Next Ticket →

#54633 closed defect (bug) (fixed)

Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS

Reported by:	Valer1e	Owned by:	audrasjb
Priority:	normal	Milestone:	6.0
Component:	Rewrite Rules	Version:
Severity:	normal	Keywords:	has-patch commit assigned-for-commit
Cc:		Focuses:	administration

Description

Here is the message, when we register the permalinks in the back office with a .htaccess non writable:

If your .htaccess file was writable, we could do this automatically, but it isn't > so these are the mod_rewrite rules you should have in your .htaccess file. Click
in the field and press CTRL + a to select all.

"CTRL + a" is different on Mac OS for example. It's possible that some people don't know how to do it? We also have a control key on Mac

Change History (10)

#1 @Valer1e
5 years ago

It would be better if we would have something like :

If your .htaccess file was writable, we could do this automatically, but it isn't so these are the mod_rewrite rules you should have in your .htaccess file. Click in the field and press CTRL + a (or ⌘ + A on mac) to select all

Last edited 5 years ago by Valer1e (previous) (diff)

#2 @SergeyBiryukov
5 years ago

Component General → Rewrite Rules
Focuses administration added
Keywords needs-patch added
Milestone Awaiting Review → 6.0

This ticket was mentioned in PR #2055 on WordPress/wordpress-develop by ajoah.

5 years ago #3

Keywords has-patch added; needs-patch removed

Patch to add Mac shortcut on permalinks page

Result :

See : https://core.trac.wordpress.org/ticket/54633

#4 @audrasjb
5 years ago

Owner set to audrasjb
Status new → assigned

Thanks for the PR @ajoah.
Looks good to me. Self assigning for commit consideration (it has to wait for 5.9 to be branched first, as it's milestoned to 6.0).

#5 @SergeyBiryukov
5 years ago

Thanks for the PR! I have a couple notes:

We refer to this Mac key as "Cmd" in the `wordpress` TinyMCE plugin bundled with core. Should we maybe do the same here, or is ⌘ a more common/recognizable name?
The same key combination is mentioned in two more instances in the same file for web.config and should be updated there as well.