Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54633 closed defect (bug) (fixed)

Updating permalinks with .htaccess non writable : the message to copy the mod_rewrite is not adapted to each OS

Reported by: valer1e's profile Valer1e Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Rewrite Rules Keywords: has-patch commit assigned-for-commit
Focuses: administration Cc:

Description

Here is the message, when we register the permalinks in the back office with a .htaccess non writable:

If your .htaccess file was writable, we could do this automatically, but it isn't > so these are the mod_rewrite rules you should have in your .htaccess file. Click
in the field and press CTRL + a to select all.

"CTRL + a" is different on Mac OS for example. It's possible that some people don't know how to do it? We also have a control key on Mac

Change History (10)

#1 @Valer1e
2 years ago

It would be better if we would have something like :

If your .htaccess file was writable, we could do this automatically, but it isn't so these are the mod_rewrite rules you should have in your .htaccess file. Click in the field and press CTRL + a (or ⌘ + A on mac) to select all

Last edited 2 years ago by Valer1e (previous) (diff)

#2 @SergeyBiryukov
2 years ago

  • Component changed from General to Rewrite Rules
  • Focuses administration added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 6.0

This ticket was mentioned in PR #2055 on WordPress/wordpress-develop by ajoah.


2 years ago
#3

  • Keywords has-patch added; needs-patch removed

Patch to add Mac shortcut on permalinks page

Result :
https://i0.wp.com/user-images.githubusercontent.com/10757301/146342996-215d1300-f450-46bd-b648-a4292e080047.png

See : https://core.trac.wordpress.org/ticket/54633

#4 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to assigned

Thanks for the PR @ajoah.
Looks good to me. Self assigning for commit consideration (it has to wait for 5.9 to be branched first, as it's milestoned to 6.0).

#5 @SergeyBiryukov
2 years ago

Thanks for the PR! I have a couple notes:

  • We refer to this Mac key as "Cmd" in the `wordpress` TinyMCE plugin bundled with core. Should we maybe do the same here, or is ⌘ a more common/recognizable name?
  • The same key combination is mentioned in two more instances in the same file for web.config and should be updated there as well.

ajoah commented on PR #2055:


2 years ago
#6

Hi @SergeyBiryukov,

Well seen :)

Tinymce refers to cmd and ⌘ too : https://core.trac.wordpress.org/browser/tags/5.8.2/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L712
So I replaced the cmd reference by ⌘.

I updated the two other mentions of the shortcut in permalinks file

audrasjb commented on PR #2055:


2 years ago
#7

Conflicts solved (merged trunk to the PR branch)

#8 @audrasjb
2 years ago

  • Keywords commit assigned-for-commit added

I refreshed the patch and I confirmed it addresses the comment above. Self assigning for commit.

#9 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53047:

Adds "select all" shortcut for Mac on permalinks page when .htaccess is not writable.

This change improves the description of the "select all" shortcut for Mac users in Permalink Settings screen.

Props Valer1e, ajoah, audrasjb, SergeyBiryukov.
Fixes #54633.

Note: See TracTickets for help on using tickets.