Changes between Initial Version and Version 1 of Ticket #54645, comment 4
- Timestamp:
- 05/28/2022 05:52:14 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #54645, comment 4
initial v1 1 1 To clarify: having a numerical name (in `style.css`) doesn't seem to create problems, while having a numerical ''folder name'' does. 2 2 3 The patch fixes this by making sure that we cast the theme dirname to a string when creating the `WP_Theme` object.3 The patch fixes this by making sure that we cast the theme dirname to a string ~~when creating the `WP_Theme` object~~ when assigning to the `stylesheet` property in the `WP_Theme` contructor. 4 4 5 5 To test, rename e.g. `wp-content/themes/twentytwentyone` to `wp-content/themes/2021`. … … 13 13 - editing a post in the block editor shows the supported features e.g. the featured image 14 14 15 I'm removing the `needs-unit-tests` keyword since there's currently no default theme with a numerical dirname to be retrieved by a call to `wp_get_themes()`.15 ~~ I'm removing the `needs-unit-tests` keyword since there's currently no default theme with a numerical dirname to be retrieved by a call to `wp_get_themes()`~~ Unit test added after change of approach.