WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #54648, comment 37


Ignore:
Timestamp:
10/11/2024 06:45:20 PM (15 months ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #54648, comment 37

    initial v1  
    11@joemcgill thanks for reviewing. Indeed when testing the previous PR it didn't work as expected.
    22
    3 Instead, we need to apply the filter and the quality right before resizing the image, after we have calculated the final dimensions. This is in the resize method of both Imagick and GD.
     3Instead, we need to apply the filter and the quality right before resizing the image, before or after we have calculated the final dimensions. This is in the resize method of both Imagick and GD.
    44
    55I have updated the [https://github.com/WordPress/wordpress-develop/pull/2189 PR] to make this change and verified the filter now passes each image size, and that the returned quality is applied when creating the sub sized images.