Opened 3 years ago
Closed 3 years ago
#54659 closed task (blessed) (fixed)
PHP 8.0/8.1: Update SimplePie to version 1.5.7
Reported by: | jrf | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | External Libraries | Keywords: | php8 php81 php82 needs-patch |
Focuses: | Cc: |
Description
A new version of SimplePie has just been released.
This version should show significant improvements in the compatibility of SimplePie with PHP 8.0, 8.1 and even contains an initial PHP 8.2 fix.
The release also contains a number of other bug fixes.
With that in mind, the SimplePie library should be updated.
Refs:
- https://github.com/simplepie/simplepie/releases/tag/1.5.7
- https://github.com/simplepie/simplepie/compare/1.5.6...1.5.7
I've done a cursory check of the changes and they look sane to me, but would very much like to invite a second opinion.
I'm not sure if this qualifies to still be included in WP 5.9, but if not, it should definitely get the 6.0 early tag.
Attachments (1)
Change History (10)
#2
@
3 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to SergeyBiryukov
- Status changed from new to accepted
#3
in reply to:
↑ 1
@
3 years ago
Replying to SergeyBiryukov:
... it looks like the
@version
tag and theSIMPLEPIE_VERSION
constant in the SimplePie.php file are incorrect: they still say1.5.6
. Should we expect a1.5.8
release to correct that?
Good question - was just going to open an issue about it and saw you already did ;-)
For reference for other people looking at this ticket: https://github.com/simplepie/simplepie/issues/708
#5
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to see if comment:3 can be addressed before 5.9 final release.
#6
@
3 years ago
@SergeyBiryukov I've raised PR https://github.com/simplepie/simplepie/pull/710 to fix the version update at SimplePie.
#7
@
3 years ago
- Keywords 2nd-opinion has-patch removed
Thank you @faisal03! Hopefully a new release can happen for 5.9.
Resetting keywords as the patch has already been committed. Follow-up in this ticket will be to update if SimplePie releases in time for 5.9.
#8
@
3 years ago
- Keywords needs-patch added
SimplePie 1.5.8 has been tagged and includes the fixed version constant + a doc fix: https://github.com/simplepie/simplepie/releases/tag/1.5.8
Thanks for the ticket!
I think this can still be included in WP 5.9, but it looks like the
@version
tag and theSIMPLEPIE_VERSION
constant in the SimplePie.php file are incorrect: they still say1.5.6
. Should we expect a1.5.8
release to correct that?