WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 4 weeks ago

#54659 closed task (blessed) (fixed)

PHP 8.0/8.1: Update SimplePie to version 1.5.7

Reported by: jrf Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: php8 php81 php82 needs-patch
Focuses: Cc:

Description

A new version of SimplePie has just been released.

This version should show significant improvements in the compatibility of SimplePie with PHP 8.0, 8.1 and even contains an initial PHP 8.2 fix.

The release also contains a number of other bug fixes.

With that in mind, the SimplePie library should be updated.

Refs:

I've done a cursory check of the changes and they look sane to me, but would very much like to invite a second opinion.

I'm not sure if this qualifies to still be included in WP 5.9, but if not, it should definitely get the 6.0 early tag.

Previous: #36669, #51521

Attachments (1)

54659.diff (16.6 KB) - added by SergeyBiryukov 5 weeks ago.

Download all attachments as: .zip

Change History (10)

#1 follow-up: @SergeyBiryukov
5 weeks ago

  • Milestone changed from Awaiting Review to 5.9

Thanks for the ticket!

I think this can still be included in WP 5.9, but it looks like the @version tag and the SIMPLEPIE_VERSION constant in the SimplePie.php file are incorrect: they still say 1.5.6. Should we expect a 1.5.8 release to correct that?

Last edited 5 weeks ago by SergeyBiryukov (previous) (diff)

@SergeyBiryukov
5 weeks ago

#2 @SergeyBiryukov
5 weeks ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#3 in reply to: ↑ 1 @jrf
5 weeks ago

Replying to SergeyBiryukov:

... it looks like the @version tag and the SIMPLEPIE_VERSION constant in the SimplePie.php file are incorrect: they still say 1.5.6. Should we expect a 1.5.8 release to correct that?

Good question - was just going to open an issue about it and saw you already did ;-)

For reference for other people looking at this ticket: https://github.com/simplepie/simplepie/issues/708

#4 @SergeyBiryukov
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52393:

External Libraries: Update the SimplePie library to version 1.5.7.

This version shows significant improvements in the compatibility of SimplePie with PHP 8.0, 8.1, and even contains an initial PHP 8.2 fix. The release also contains a number of other bug fixes.

Release notes: https://github.com/simplepie/simplepie/releases/tag/1.5.7

For a full list of changes in this update, see the SimplePie GitHub:
https://github.com/simplepie/simplepie/compare/1.5.6...1.5.7

Follow-up to [47733], [49176].

Props jrf, SergeyBiryukov.
Fixes #54659.

#5 @SergeyBiryukov
5 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to see if comment:3 can be addressed before 5.9 final release.

#6 @faisal03
5 weeks ago

@SergeyBiryukov I've raised PR https://github.com/simplepie/simplepie/pull/710 to fix the version update at SimplePie.

#7 @hellofromTonya
5 weeks ago

  • Keywords 2nd-opinion has-patch removed

Thank you @faisal03! Hopefully a new release can happen for 5.9.

Resetting keywords as the patch has already been committed. Follow-up in this ticket will be to update if SimplePie releases in time for 5.9.

#8 @jrf
4 weeks ago

  • Keywords needs-patch added

SimplePie 1.5.8 has been tagged and includes the fixed version constant + a doc fix: https://github.com/simplepie/simplepie/releases/tag/1.5.8

#9 @SergeyBiryukov
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52413:

External Libraries: Update the SimplePie library to version 1.5.8.

This minor update corrects the SIMPLEPIE_VERSION constant and updates the changelog after the previous release.

Release notes: https://github.com/simplepie/simplepie/releases/tag/1.5.8

For a full list of changes in this update, see the SimplePie GitHub:
https://github.com/simplepie/simplepie/compare/1.5.7...1.5.8

Follow-up to [47733], [49176], [52393].

Props faisal03, jrf, audrasjb, SergeyBiryukov.
Fixes #54659.

Note: See TracTickets for help on using tickets.