WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 4 weeks ago

#54669 new enhancement

Remove ONLY_FULL_GROUP_BY from incompatible wpdb modes

Reported by: malthert Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.9
Component: Database Keywords: needs-patch needs-unit-tests
Focuses: Cc:

Description

as GROUP BY is non-deterministic otherwise, ONLY_FULL_GROUP_BY ensures this is not the case.
which is why this is enabled by default since MySQL 8

I guess it was disabled originally, as some queries would have to be updated in WP core.

I think however, this should be done now, as otherwise we're accumulating more and more technical debt.

Change History (2)

#1 @johnbillion
4 weeks ago

  • Keywords needs-patch needs-unit-tests added
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

#2 @SergeyBiryukov
4 weeks ago

  • Version set to 3.9

Thanks for the ticket!

Introduced in [27072] / #26847, see comment:2:ticket:26847 for context.

Related: #44586, #48280, #48377, #49344

Note: See TracTickets for help on using tickets.