#54670 closed defect (bug) (fixed)
Gutenberg / newly introduced functions referring to non-existent class properties
Reported by: | jrf | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Editor | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Commit [52062] in response to ticket #54335 introduced the _build_block_template_result_from_file()
and _build_block_template_result_from_post()
functions in the wp-includes/block-template-utils.php
file.
These functions directly set properties on the WP_Block_Template
class, but are assigning to some properties which don't exist on the class.
This should be fixed.
Change History (6)
This ticket was mentioned in PR #2072 on WordPress/wordpress-develop by jrfnl.
3 years ago
#1
#2
@
3 years ago
GitHub PR https://github.com/WordPress/wordpress-develop/pull/2072 addresses this.
#3
@
3 years ago
- Keywords commit added
Marking PR 2072 for commit.
Opened an issue in the Gutenberg repository to backport the changes to Gutenberg https://github.com/WordPress/gutenberg/issues/37533.
#4
@
3 years ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Self-assigning to prepare the commit.
hellofromtonya commented on PR #2072:
3 years ago
#6
Committed via changeset https://core.trac.wordpress.org/changeset/52397.
The
$post_types
and$area
properties are being assigned to from the_build_block_template_result_from_file()
and_build_block_template_result_from_post()
functions, which were introduced in WP 5.9, but these properties do not explicitly exist on theWP_Block_Template
class.Trac ticket: [](https://core.trac.wordpress.org/ticket/54670)