#54673 closed enhancement (fixed)
Improve formatting in `/wp-admin/user-edit.php`.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.0 | Priority: | normal |
| Severity: | normal | Version: | 5.9 |
| Component: | Administration | Keywords: | has-patch early commit |
| Focuses: | coding-standards | Cc: |
Description
Follow-up to #53658. See this comment on PR 2069.
The formatting in this file can cause PHPCS failures when adding new code. This requires new code to be indented multiple times, breaking alignment of the HTML. This makes for difficult reading.
In PR 2069, we used // phpcs: disable ... // phpcs: enable for the failing sniffs to preserve alignment of the HTML. This is messy, and would need to be implemented for similar future changes.
Let's fixup this file so that we can remove the annotations and save further workarounds in future.
Attachments (5)
Change History (14)
This ticket was mentioned in PR #2096 on WordPress/wordpress-develop by johnregan3.
2 years ago
#1
- Keywords has-patch added; needs-patch removed
johnregan3 commented on PR #2096:
21 months ago
#4
Updated to fix merge conflicts.
#5
@
21 months ago
- Keywords commit added
Reviewed linked pull request with white space suppressed.
The changes look good to me. Screenshots comparing the screens between the proposed changes and trunk show no apparent difference.
21 months ago
#8
Committed in https://core.trac.wordpress.org/changeset/52820
Improves formatting in
/wp-admin/user-edit.php. Fixes formatting errors caught by PHPCS.Trac ticket: https://core.trac.wordpress.org/ticket/54673
I've run PHP Unit tests and everything passed (except for the expected skips and risky tests).
Should I update the strict comparison (== vs ===) errors, or are we concerned that some developers might be dependent on the not-strict comparison operators?