Names for new wp-login.php filter

[kebbet]

I think the newly intruduced filters in 5.9 should be renamed for more consisteny with other filters in wp-login.php.

display_login_language_dropdown => login_language_display_dropdown
wp_login_language_switcher_args => login_language_switcher_args

Example of existing filters

• login_enqueue_scripts
• login_title
• login_site_html_link
• login_headerurl
• login_headertext

Trac ticket:
https://core.trac.wordpress.org/ticket/54696

[kebbet]

Or possibly login_display_language_dropdown.

[mukesh27]

This make sense for me.

Replying to kebbet:

Or possibly login_display_language_dropdown.

[audrasjb]

These changes require to adjust the already published dev note: ​https://make.wordpress.org/core/2021/12/20/introducing-new-language-switcher-on-the-login-screen-in-wp-5-9/

[audrasjb]

This change looks relevant to me, even if we would still have some inconsistent filters like wp_login_errors.

Also, login_display_language_dropdown seems better than login_language_display_dropdown.

[audrasjb]

PR updated to use login_display_language_dropdown.

[audrasjb]

My only concern with the proposed name for the filter is that the order of the words in "login_display_language_dropdown" doesn't look "natural".
@SergeyBiryukov do we have a best practice for this?

There is nothing about word order in the PHP coding standards handbook page: ​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/

[kebbet]

Maybe remove display from name? Or add something with visibility at the end and remove display?

[Clorith]

login_display_language_dropdown seems correct to me, login_ prefixing the pålacement of the filter, and then the "descriptive" naming of "display language dropdown" yes/no (true/false).

[hellofromTonya]

I agree. login_display_language_dropdown looks good to me too. The login_ prefix is consistent with many of the other filters in the same file. Marking ​PR 2085 for commit.

[audrasjb]

Alright, thank you @hellofromTonya and @Clorith, I'll commit this right now 👍

[audrasjb]

I'll update the related dev note once it's committed.

[audrasjb]

In 52432:

Login and registration: Rename two filters related to language dropdown for better consistency.

This change renames two filters introduced in WP 5.9 development cycle. It replaces display_login_language_dropdown with login_display_language_dropdown and wp_login_language_switcher_args with login_language_switcher_args, for better consistency with the other existing login_* filters.

Props kebbet, mukesh27, audrasjb, Clorith, hellofromTonya.
Fixes #54696.

Committed in https://core.trac.wordpress.org/changeset/52432

[audrasjb]

Just updated the dev note accordingly: ​https://make.wordpress.org/core/2021/12/20/introducing-new-language-switcher-on-the-login-screen-in-wp-5-9/

[SergeyBiryukov]

Sorry for reopening again, could we rename login_language_switcher_args to login_language_dropdown_args?

That would be more consistent with some other *_dropdown_args filters:

• taxonomy_parent_dropdown_args
• post_edit_category_parent_dropdown_args
• widget_archives_dropdown_args
• widget_categories_dropdown_args

It would also be more consistent with the new login_display_language_dropdown filter, which uses the dropdown term instead of switcher.

Trac ticket: https://core.trac.wordpress.org/ticket/54696

[faisal03]

@SergeyBiryukov Just did it ​https://github.com/WordPress/wordpress-develop/pull/2111

[audrasjb]

Good point @SergeyBiryukov!

Thanks for the PR @faisal03, it looks good to me.

[audrasjb]

Checks are passing on the PR, I'll commit this right now.

[audrasjb]

Re-adding needs-dev-note keyword, to not forget to update the existing devnote.

[audrasjb]

In 52435:

Login and registration: Rename login_language_switcher_args to login_language_dropdown_args.

This change adds better consistency with the other *_dropdown_args filters, like taxonomy_parent_dropdown_args or widget_archives_dropdown_args. It is also more consistent with the new login_display_language_dropdown filter.

Props SergeyBiryukov, faisal03.
Fixes #54696.

[audrasjb]

Devnote updated accordingly: ​https://make.wordpress.org/core/2021/12/20/introducing-new-language-switcher-on-the-login-screen-in-wp-5-9/

Committed via https://core.trac.wordpress.org/changeset/52435.