Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#54710 closed enhancement (invalid)

Translators comments are missing in many files

Reported by: yagniksangani's profile yagniksangani Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: I18N Keywords: has-patch
Focuses: coding-standards Cc:

Description

Translators comments are missing in many files

Attachments (1)

54710.diff (11.7 KB) - added by yagniksangani 3 years ago.
Diff File

Download all attachments as: .zip

Change History (6)

#1 @audrasjb
3 years ago

Hello,
Could you please provide more details about the related strings?
Thank you

@yagniksangani
3 years ago

Diff File

#2 follow-up: @SergeyBiryukov
3 years ago

  • Keywords close added

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

At a glance, these are all just static strings used for sprintf(), they are not translatable and therefore don't need translator comments.

#3 @SergeyBiryukov
3 years ago

  • Component changed from Comments to I18N

#4 @SergeyBiryukov
3 years ago

It's also worth noting that we have automated checks for missing translator comments in all of core files as part of WordPress Coding Standards PHPCS checks, and the tests would fail if any translatable string with a placeholder is missing a translator comment.

See [45604] & [45609] / #47632, [45926] / #44360.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

#5 in reply to: ↑ 2 @desrosj
2 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

At a glance, these are all just static strings used for sprintf(), they are not translatable and therefore don't need translator comments.

I agree with this assessment. Closing as there's nothing incorrect here as described.

Note: See TracTickets for help on using tickets.