Context Navigation

← Previous Ticket
Next Ticket →

#54711 closed task (blessed) (fixed)

Build/Tools: Update PHPCompatibilityWP

Reported by:	jrf	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.9
Component:	Build/Test Tools	Version:	5.9
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	coding-standards

Description

I've just released a new version of PHPCompatibilityWP which takes the new polyfills added in WP 5.9 into account.

Updating is recommended. GitHub patch upcoming.

Ref: https://github.com/PHPCompatibility/PHPCompatibilityWP/releases/tag/2.1.3

Change History (6)

This ticket was mentioned in PR #2095 on WordPress/wordpress-develop by jrfnl.

5 years ago #1

Keywords has-patch added

... and remove redundant inline ignore comments for WP polyfilled functionality. The PHPCompatibilityWP ruleset explicitly excludes those polyfills, so they don't need to be annotated as ignored.

Ref:

https://github.com/PHPCompatibility/PHPCompatibilityWP/releases/tag/2.1.3

Trac ticket: https://core.trac.wordpress.org/ticket/54711

#2 @jrf
5 years ago

Keywords has-patch removed

GitHub PR https://github.com/WordPress/wordpress-develop/pull/2095 contains a comprehensive patch for this (including some clean up).

#3 @jrf
5 years ago

Keywords has-patch added

#4 @SergeyBiryukov
5 years ago

Milestone Awaiting Review → 5.9

#5 @SergeyBiryukov
5 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 52425:

Build/Test Tools: Update PHPCompatibilityWP to version 2.1.3.

The latest release takes the new polyfills added in WordPress 5.9 into account.

This commit also removes redundant inline ignore comments for WP-polyfilled functionality. The PHPCompatibilityWP ruleset explicitly excludes those polyfills, so they don't need to be annotated as ignored.

Release notes:
https://github.com/PHPCompatibility/PHPCompatibilityWP/releases/tag/2.1.3

For a full list of changes in this update, see the PHPCompatibilityWP GitHub:
https://github.com/PHPCompatibility/PHPCompatibilityWP/compare/2.1.2...2.1.3

Follow-up to [46290], [51543].

Props jrf.
Fixes #54711.

jrfnl commented on PR #2095:

5 years ago #6

Closing as merged via changeset 52425

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#54711 closed task (blessed) (fixed)

Build/Tools: Update PHPCompatibilityWP

Description

Change History (6)

This ticket was mentioned in ​PR #2095 on ​WordPress/wordpress-develop by ​jrfnl. 5 years ago #1

#2 @jrf 5 years ago

#3 @jrf 5 years ago

#4 @SergeyBiryukov 5 years ago

#5 @SergeyBiryukov 5 years ago

​jrfnl commented on ​PR #2095: 5 years ago #6