WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#54711 closed task (blessed) (fixed)

Build/Tools: Update PHPCompatibilityWP

Reported by: jrf Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: trunk
Component: Build/Test Tools Keywords: has-patch
Focuses: coding-standards Cc:

Description

I've just released a new version of PHPCompatibilityWP which takes the new polyfills added in WP 5.9 into account.

Updating is recommended. GitHub patch upcoming.

Ref: https://github.com/PHPCompatibility/PHPCompatibilityWP/releases/tag/2.1.3

Change History (6)

This ticket was mentioned in PR #2095 on WordPress/wordpress-develop by jrfnl.


3 weeks ago

  • Keywords has-patch added

... and remove redundant inline ignore comments for WP polyfilled functionality. The PHPCompatibilityWP ruleset explicitly excludes those polyfills, so they don't need to be annotated as ignored.

Ref:

Trac ticket: https://core.trac.wordpress.org/ticket/54711

#2 @jrf
3 weeks ago

  • Keywords has-patch removed

GitHub PR https://github.com/WordPress/wordpress-develop/pull/2095 contains a comprehensive patch for this (including some clean up).

#3 @jrf
3 weeks ago

  • Keywords has-patch added

#4 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 5.9

#5 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 52425:

Build/Test Tools: Update PHPCompatibilityWP to version 2.1.3.

The latest release takes the new polyfills added in WordPress 5.9 into account.

This commit also removes redundant inline ignore comments for WP-polyfilled functionality. The PHPCompatibilityWP ruleset explicitly excludes those polyfills, so they don't need to be annotated as ignored.

Release notes:
https://github.com/PHPCompatibility/PHPCompatibilityWP/releases/tag/2.1.3

For a full list of changes in this update, see the PHPCompatibilityWP GitHub:
https://github.com/PHPCompatibility/PHPCompatibilityWP/compare/2.1.2...2.1.3

Follow-up to [46290], [51543].

Props jrf.
Fixes #54711.

#6 @prbot
3 weeks ago

jrfnl commented on PR #2095:

Closing as merged via changeset 52425

Note: See TracTickets for help on using tickets.