Make WordPress Core

Opened 2 years ago

Closed 19 months ago

#54741 closed enhancement (fixed)

About page - use version as variable

Reported by: presskopp's profile Presskopp Owned by: davidbaumwald's profile davidbaumwald
Milestone: 6.1 Priority: normal
Severity: normal Version: 5.9
Component: Help/About Keywords: has-patch
Focuses: Cc:

Description

what about using a variable for the version in the "field guide" string?

Attachments (5)

54741.diff (879 bytes) - added by Presskopp 2 years ago.
54741.2.diff (1.0 KB) - added by costdev 2 years ago.
PHPCS fixes + Translator comment updated.
54741.3.diff (1016 bytes) - added by Presskopp 2 years ago.
54741.4.diff (1.0 KB) - added by Presskopp 2 years ago.
patch makes the url translatable and also adjusted it from giving a 'Page Not Found'
54741.5.diff (1.6 KB) - added by SergeyBiryukov 20 months ago.

Download all attachments as: .zip

Change History (13)

@Presskopp
2 years ago

@costdev
2 years ago

PHPCS fixes + Translator comment updated.

#1 @Presskopp
2 years ago

You say The WordPress version.

Maybe we should be consistent in the comments and say WordPress version number like in 5 other instances in the about.php file

@Presskopp
2 years ago

This ticket was mentioned in Slack in #core by abhanonstopnews. View the logs.


2 years ago

#3 @audrasjb
2 years ago

  • Keywords needs-refresh added

The idea looks good to me, but I’d suggest the field guide url could be translatable as well, since some Locales are translating this post.

@Presskopp
2 years ago

patch makes the url translatable and also adjusted it from giving a 'Page Not Found'

#4 @marybaum
20 months ago

  • Keywords needs-unit-tests added
  • Milestone changed from Awaiting Review to 6.1

Just applied the most recent patch, and it seems to work!

#5 @SergeyBiryukov
20 months ago

  • Keywords needs-refresh needs-unit-tests removed

The previous patch includes a link to the WordPress 5.9 Field Guide, which is no longer there in 6.0.

54741.5.diff applies the suggested changes to the current About page:

  • It looks like the Field Guide string was already made reusable for multiple releases in [53339] / #55434.
  • The patch makes the Release Notes string reusable too.

#6 @audrasjb
20 months ago

Looks good to me, thanks Sergey! 👌

#7 @marybaum
20 months ago

Props @oglekler and @webcommsat for help on today’s component scrub!

#8 @davidbaumwald
19 months ago

  • Owner set to davidbaumwald
  • Resolution set to fixed
  • Status changed from new to closed

In 54219:

Help/About: Make translator comments version agnostic and make version translatable on the About page.

In past versions of the About page, translator comments referencing the Field Guide and Release Notes links included the current version number. This change updates these translator comments to remove a specific version number, which was not necessary.

This change also abstracts the version number out of the "Read the WordPress X.X Release Notes" string, making it translatable.

Props Presskopp, audrasjb, SergeyBiryukov, marybaum.
Fixes #54741.

Note: See TracTickets for help on using tickets.