WordPress.org

Make WordPress Core

Opened 2 weeks ago

Closed 12 days ago

#54745 closed defect (bug) (fixed)

REST API: Wrong punctuation in `$schema['properties']['object']` description

Reported by: La Geek Owned by: audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version: trunk
Component: Text Changes Keywords: i18n-change has-patch dev-reviewed commit fixed-major
Focuses: Cc:

Description

The type of object originally represented, such as "category," "post", or "attachment."

should be

The type of object originally represented, such as "category", "post", or "attachment".

Referenz:
https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php?marks=819#L819

translate.w.org:
https://translate.wordpress.org/projects/wp/dev/de/formal/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=12959314&filters%5Btranslation_id%5D=91360190

Attachments (2)

54745.diff (856 bytes) - added by audrasjb 2 weeks ago.
Patch generated against branch 5.9
54745.2.diff (856 bytes) - added by audrasjb 2 weeks ago.

Download all attachments as: .zip

Change History (13)

#1 @audrasjb
2 weeks ago

  • Keywords i18n-change added
  • Owner set to audrasjb
  • Status changed from new to assigned
  • Summary changed from Wrong punctuation to REST API: Wrong punctuation in `$schema['properties']['object']` description

#2 @audrasjb
2 weeks ago

  • Milestone changed from Awaiting Review to 5.9

Hello, thank you for spotting this!

Moving for 5.9 consideration.
We're in hard string freeze though, so we'll see if it's better to fix this in 5.9 or 5.9.1.

Last edited 2 weeks ago by audrasjb (previous) (diff)

@audrasjb
2 weeks ago

Patch generated against branch 5.9

#3 @audrasjb
2 weeks ago

  • Keywords dev-feedback has-patch added

Reminder: as we entered release candidate commit will require double-signoff using the dev-feedback and dev-reviewed Trac keywords.

#4 @La Geek
2 weeks ago

You are welcome.

"category,"

needs a change too ;-)

"category",

Thanks.

@audrasjb
2 weeks ago

#5 @tobifjellner
2 weeks ago

I'd vote for fixing this before 5.9 is released, despite the string freeze.
I believe it's important that core, as much as possible, show the right way to handle various strings.
(And this is a tricky one, since English actually does place commas, etc before the closing quotation mark, but here is not a quotation, but a string delimiter.

#6 @hellofromTonya
2 weeks ago

  • Keywords dev-reviewed commit added; dev-feedback removed

Hmm, the context of these quotations is not to quote someone but rather to denote a specific thing such as a category or post. Quoting someone in English would place the punctation inside of the closing quotation mark as @tobifjellner notes.

Given that the quotation marks are different here, I think 54745.2.diff is the more correct version.

#7 @audrasjb
2 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52535:

REST API: Typo correction in a link description object.

This change fixes a wrong punctuation in a link description object of the menu items controller endpoint.

Props la-geek, audrasjb, tobifjellner, hellofromtonya.
Fixes #54745.

#8 @audrasjb
2 weeks ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to branch 5.9.

#9 @audrasjb
2 weeks ago

In 52536:

Tests: Update qUnit test fixtures after [52535].

See #54745.

#10 @audrasjb
12 days ago

Checks are passing for both commits. Let's backport this to branch 5.9.

#11 @audrasjb
12 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52541:

REST API: Typo correction in a link description object.

This change fixes a wrong punctuation in a link description object of the menu items controller endpoint. It also updates qUnit test fixtures accordingly.

Props la-geek, audrasjb, tobifjellner, hellofromtonya, davidbaumwald.
Merges [52535] and [52536] to the 5.9 branch.
Fixes #54745.

Note: See TracTickets for help on using tickets.