Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54762 closed defect (bug) (fixed)

Site breaking if "full-site-editing" tag in use and Gutenberg plugin disabled

Reported by: ajcreate's profile ajcreate Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8.2
Component: Customize Keywords:
Focuses: Cc:

Description

This happened while editing a custom theme that did not have FSE fully implemented.

I added the tag "full-site-editing" to the tag list in my custom theme's style.css file.

I had the Gutenburg plugin installed, and my theme and site worked fine.

On deactivation of the Gutenberg plugin, the "Publish" button in the Customize area was greyed out and read "Cannot Activate". I was no longer able to publish with Gutenburg deactivated.

There were no other errors and nothing was picked up on any Debugging tools that I used.

Removing the tag "full-site-editing" from my style.css fixed the issue.

I can see there might be something in WP theme.php that might be in place to display an error, although nothing showed up to point me in the right direction.

I tried to replicate this situation by adding the "full-site-editing" tag to WP twentytwentyone theme and I experienced the same issue.

Change History (5)

#1 @costdev
2 years ago

Hi @ajcreate, thanks for opening this ticket and welcome to Trac!

Test Report

Env

  • WordPress 5.8.3 and 5.9 RC1
  • Chrome 97.0.4692.71
  • Windows 10
  • Theme: Twenty Twenty-One
  • Plugin: None activated

Steps to test

  1. Navigate to Appearance > Customize.
  2. The "Publish" button should be visible.
  3. Add full-site-editing to Tags in Twenty Twenty-One's style.css.
  4. Refresh the Customize screen.
  5. The "Publish" button has been replaced by "Cannot Activate".

Results

  • Reproduced on 5.8.3.
  • Cannot reproduce in 5.9 RC1. This appears to have been fixed in 5.9.

#2 follow-up: @costdev
2 years ago

  • Keywords reporter-feedback added

@ajcreate If this is a development environment, can you do the following to verify that the issue is resolved for you in 5.9 RC1?

Steps to test

  1. Install and activate the WordPress Beta Tester plugin.
  2. Navigate to Tools > Beta Testing.
  3. Tick "Bleeding Edge".
  4. Click "Save Changes".
  5. Tick "Release Candidates Only".
  6. Click "Save Changes".
  7. Navigate to Dashboard > Updates.
  8. Click "Update to version 5.9-RC1".
  9. Add full-site-editing to Tags in Twenty Twenty-One's style.css.
  10. Navigate to Appearance > Customize.
  11. Verify that the "Publish" button is available.

Cleanup

  1. Navigate to Dashboard > Updates.
  2. Click "Re-install version 5.8.(2/3)".
  3. Deactivate and delete the WordPress Beta Tester plugin.
  4. Remove full-site-editing from Tags in Twenty Twenty-One's style.css.

#3 in reply to: ↑ 2 @ajcreate
2 years ago

Replying to costdev:

@ajcreate If this is a development environment, can you do the following to verify that the issue is resolved for you in 5.9 RC1?

Steps to test

  1. Install and activate the WordPress Beta Tester plugin.
  2. Navigate to Tools > Beta Testing.
  3. Tick "Bleeding Edge".
  4. Click "Save Changes".
  5. Tick "Release Candidates Only".
  6. Click "Save Changes".
  7. Navigate to Dashboard > Updates.
  8. Click "Update to version 5.9-RC1".
  9. Add full-site-editing to Tags in Twenty Twenty-One's style.css.
  10. Navigate to Appearance > Customize.
  11. Verify that the "Publish" button is available.

Cleanup

  1. Navigate to Dashboard > Updates.
  2. Click "Re-install version 5.8.(2/3)".
  3. Deactivate and delete the WordPress Beta Tester plugin.
  4. Remove full-site-editing from Tags in Twenty Twenty-One's style.css.

Hi @costdev,

Thank you for the quick response.

I can confirm after following the steps listed above, that the publish button is available when the full-site-editing tag is in use.

Thank you!

#4 @ajcreate
2 years ago

  • Keywords reporter-feedback removed

#5 @hellofromTonya
2 years ago

  • Milestone changed from Awaiting Review to 5.9
  • Resolution set to fixed
  • Status changed from new to closed

Thank you @ajcreate for confirming this is fixed in 5.9. Thank you @costdev for testing and guidance. I'll close this ticket as fixed.

Note: See TracTickets for help on using tickets.