Make WordPress Core

Changes between Version 4 and Version 5 of Ticket #54764, comment 7


Ignore:
Timestamp:
01/13/2022 07:29:34 AM (2 years ago)
Author:
shreyasikhar26
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #54764, comment 7

    v4 v5  
     1
     2Replying to [comment:6 costdev]:
     3> The "squashed" preview occurs both when viewing the Theme Details `.theme-overlay iframe` and the Customizer `#customize-container iframe`.
     4>
     5> [https://github.com/WordPress/wordpress-develop/pull/2146 PR 2146] changes the width from `100%` to `100vw`. In doing so, a previously "squashed" preview (based on remaining available container space) becomes a "true" preview (based on the user's viewport width).
     6>
     7> As expected, this PR resolves the issue in both locations.
     8>
     9> Great work @shreyasikhar26! Marking with `commit` for final review.
     10Thank you for the appreciation.\\
     11 
     12Can we add css overflow to the parent of iframe (for which the width property is modified in the added patch), as current patch is not allowing to scroll new theme preview horizontally to see the complete content of the theme ?