Changes between Initial Version and Version 1 of Ticket #54769, comment 1
- Timestamp:
- 01/09/2022 12:09:16 AM (4 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #54769, comment 1
initial v1 3 3 While `AS` is an optional keyword in SQL, meaning that this isn't a `defect (bug)`, it is commonly considered best practice to include the `AS` keyword for better readability and compatibility. 4 4 5 To my knowledge, this doesn't fall under any of the official coding standards in WordPress, but this query and ''almost'' every other `INNER JOIN` that uses aliases in Core includes the `AS` keyword - the one other exception I could find was in `src \wp-includes\taxonomy.php:2536`.5 To my knowledge, this doesn't fall under any of the official coding standards in WordPress, but this query and ''almost'' every other `INNER JOIN` that uses aliases in Core includes the `AS` keyword - the one other exception I could find was in `src/wp-includes/taxonomy.php:2536`. 6 6 7 7 For the reason(s) above as well as consistency in Core, I think we should add the `AS` keyword in both of these files.