WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#5477 closed enhancement (fixed)

"Go back" links when e-mail errors appear on wp-admin/install.php

Reported by: CaioAlonso Owned by: jacobsantos
Milestone: 2.8 Priority: lowest
Severity: trivial Version: 2.5
Component: Administration Keywords: has-patch tested commit
Focuses: Cc:

Description

When installing wordpress, if you commit an error when filling the e-mail form, there is no "go back" link to go back to the formulary page and correct your error.

Attachments (3)

install.php.diff (1.1 KB) - added by CaioAlonso 8 years ago.
install-php.diff (2.2 KB) - added by JDTrower 8 years ago.
Provides a "Go Back" link when a user fails to enter or enters an invalid email address at install while allowing the form fields to remember what had been entered.
5477.r10258.diff (5.3 KB) - added by jacobsantos 7 years ago.
Patch is based off of r10258

Download all attachments as: .zip

Change History (10)

@CaioAlonso8 years ago

comment:1 @CaioAlonso8 years ago

  • Keywords has-patch added; install removed

@JDTrower8 years ago

Provides a "Go Back" link when a user fails to enter or enters an invalid email address at install while allowing the form fields to remember what had been entered.

comment:2 @JDTrower8 years ago

  • Keywords needs-testing added

The original patch worked, however I felt that it was poor form to have a go back button that took you back to the formulary page that didn't have any of the information that the user had entered.

install-php.diff solves that. If a user fails to enter an email address or enters an invalid email address, it results in an error with a go back button. Clicking this button takes the user back to formulary page, but it has the information that the user had entered original already populated in the fields. I believe this is better. This patch works for me.

comment:3 @ffemtcj7 years ago

  • Milestone changed from 2.5 to 2.6

comment:4 @migol7 years ago

Maybe some JavaScript checks will help?

comment:5 @jacobsantos7 years ago

  • Keywords tested dev-feedback added; needs-testing removed
  • Milestone changed from 2.9 to 2.8

Is there a reason the back button couldn't just be used?

Sending to 2.8 since it has a patch.

@jacobsantos7 years ago

Patch is based off of r10258

comment:6 @jacobsantos7 years ago

  • Keywords commit added; dev-feedback removed
  • Owner changed from anonymous to jacobsantos

Commit this please.

comment:7 @westi7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10574]) Improve the installer when people enter a duff email address. Fixes #5477 props jacobsantos.

Note: See TracTickets for help on using tickets.