Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54770 closed enhancement (fixed)

The term "Current Theme" is ambiguous

Reported by: presskopp's profile Presskopp Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: ui, administration Cc:

Description

For example in the themes view the active theme is marked as "current theme", while in the Customizer it is marked as "active theme". I'd like to switch all ocurrences of "current theme" to "active theme" to be consistent on the one hand and to avoid misunderstandings on the other, because it can be read/translated as "updated"

Change History (18)

#1 @Presskopp
2 years ago

ocurrences occurrences

This ticket was mentioned in PR #2125 on WordPress/wordpress-develop by audrasjb.


2 years ago
#2

  • Keywords has-patch added

#3 @audrasjb
2 years ago

  • Milestone changed from Awaiting Review to 6.0
  • Owner set to audrasjb
  • Status changed from new to accepted

This totally makes sense to me.

In order to make it easier to ship and because there is a lot of changes in the whole source code, I'd suggest to make an early 6.0 change to replace "Current theme" with "Active theme" in user facing strings, first.

Once it's committed, we can update the various docblocks accordingly.

The above PR is a first step and replaces all the user facing strings in core.

#4 @audrasjb
2 years ago

Thanks @costdev for reviewing the PR. I edited the string change you pointed out ;)

#5 @audrasjb
2 years ago

  • Keywords commit added

Checks are passing. Marking this for commit.

#6 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52580:

Administration: Replace "Current theme" with "Active theme" in user facing strings.

This change replaces "Current theme" with "Active theme" in user-facing strings. It brings better consistency across the Administration.

Props Presskopp, audrasjb, costdev.
Fixes #54770.

#8 @audrasjb
2 years ago

In 52610:

Docs: Replace "Current theme" with "Active theme" in various DocBlocks.

This change replaces "Current theme" with "Active theme" in various DocBlocks for better consistency with user-facing strings.

Follow-up to [52580].

Props Presskopp, audrasjb, costdev.
Fixes #54831.
See #54770.

#9 @johnjamesjacoby
2 years ago

I won’t suggest reverting all of this work 😅 but to me “current” seems more accurate – “currently active” would be most accurate, both relative to “previously active” or simply inert.

I think that “active” makes sense for plugins, which can be activated or deactivated independent of one another, but you can’t have multiple themes active, there is simply the current(ly active) one and never any others (parent and child themes, not withstanding).

Thoughts? 😬

Last edited 2 years ago by johnjamesjacoby (previous) (diff)

#10 @audrasjb
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Let's reopen this ticket to discuss this change (or should we move to the original ticket #54770?)

#11 @Presskopp
2 years ago

I'd like to know what impact a decision here would have on various international translations. As we can see, at least for german we created an issue of possible misinterpretation. "Current" (without context) would obviously translated as "updated" and that's just not correct. So we need to be able to descern between "THE active/current" theme and all the other themes. "currently active" could work, but I'm not sure if it gets understood the way it needed to be. I don't see a problem when a theme is marked as active when no other theme can be active.
Somehow related: #54533

Version 0, edited 2 years ago by Presskopp (next)

#12 @SergeyBiryukov
2 years ago

  • Component changed from Text Changes to Themes
  • Focuses ui administration added

#13 @peterwilsoncc
2 years ago

  • Keywords commit removed

To keep the report accurate, I am removing the commit keyword while discussion ensues.

FWIW, I think "active" is a fine term. The number of items permitted to be active at any one time doesn't affect whether they are active.

#14 @costdev
2 years ago

With 6.0 Beta 1 released yesterday, I'm mindful that this enhancement ticket is still in the queue for the 6.0 milestone. Do we have any further input on this discussion?

#15 @costdev
2 years ago

This is an enhancement that had commits in the 6.0 milestone.

With Beta 3 and soft string freeze arriving on Tuesday, is there anything actionable left for this ticket?

My thoughts on the discussion:

The theme
Which one?

The current theme
Currently what? Installed or active?

The currently active theme
What was the previously active theme? We don't have that functionality.

Being able to change the active theme is the same as being able to change the site title. We don't say "Current site title".

The active theme
Clean and simple.

#16 @knutsp
2 years ago

On Multisite, when editing a site, the site can have none, one, or multiple active themes. This means available for the site admin to choose from. If that is not changed (to, say "Available Themes" and Activate to "Make available"), I would prefer the term "Current Theme" in a single site context.

I can't see "Current Theme" can mean anything else than the currently active theme, as other installed themes are not "current". And then the verb Activate for a theme should may be change to "Make current".

#17 @costdev
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This is an enhancement ticket that also touches strings. As we are past feature freeze and soft string freeze, I'm going to close this as fixed so that the original commit stays on the correct milestone. Further discussion/changes should be done in a follow-up ticket.

This ticket was mentioned in Slack in #core-multisite by knutsp. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.