Typo for home template

[talldanwp]

Originally reported in Gutenberg - ​https://github.com/WordPress/gutenberg/issues/37841

To reproduce

1. Visit the site editor
2. Using the 'W' icon, open the sidebar
3. Select 'Templates'
4. Note that the description of the Home template has a typo ("it" at the end should be "isn't").

I'm unsure if this can be fixed for 5.9 as we're now in the hard string freeze phase. If not, we can punt to 5.9.1.

At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (​https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).

See #54787, ​https://github.com/WordPress/gutenberg/pull/37843

Fixes a typo in the home template description. To test:

1. Visit the site editor
2. Using the 'W' icon, open the sidebar
3. Select 'Templates'
4. Note that the description of the Home template has a typo ("it" at the end should be "isn't").

[SergeyBiryukov]

Replying to talldanwp:

At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (​https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).

Thanks for the ticket! I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.

[tobifjellner]

It should be mentioned that up until about one year ago, the threshold for generation of language packs for core was 100%, any late string change might delay the generation of localized WordPress packs.

But now the thresholds are lowered a bit. In other words, a few late string changes may mean that an occasional untranslated string may show up in a localized package, but we can allow us to be a bit less nervous about breaking stuff.

I'd also like to mention that the original reporter was @kharisblank

[hellofromTonya]

The fix looks good to me and marking for commit.

What about the backport to 5.9 for RC2?

5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen.

Referencing @SergeyBiryukov's comment:

I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.

[hellofromTonya]

Self-assigning for commit to trunk.

[hellofromTonya]

In 52554:

Site Editor: Fix typo in home template translatable description.

The home template's description should be: "Displays as the site's home page, or as the Posts page when a static home page isn't set." This commit fixes the typo changing "it" to "isn't".

Follow-up to [52331].

Props kharisblank, talldanwp.
Fixes #54787.

[hellofromTonya]

Reopening for second committer review and opinion to backport to 5.9-branch.

As noted, 5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen. If yes, please mark as dev-reviewed.

[hellofromTonya]

In 52556:

Editor: Fix enqueueing additional styles in wp_enqueue_block_style() to print only when blocks render.

In a block theme, additional block styles registered using the wp_enqueue_block_style function should only get printed when the block exists on a page. However, they currently always get rendered.

This commit is a backport from Gutenberg that fixes the issue by printing the styles when a block renders.

Follow-up to [52069].

Props poena, aristath, Mamaduka.
Fixes #54787.

[hellofromTonya]

Whoopsie, [52556] does not belong to this ticket. It belongs to #54790.

[SergeyBiryukov]

[52554] looks good to backport.

[audrasjb]

Do we really need to use \ here?

[audrasjb]

We should use the ’ HTML entity.

[hellofromTonya]

There are other cases of \' that should use the ’ HTML entity. Should those also be fixed? Or is fixing these as a group better for 5.9.1 given that 5.9 is in hard string freeze?

[SergeyBiryukov]

Replying to hellofromTonya:

There are other cases of \' that should use the ’ HTML entity. Should those also be fixed?

I'd say yes, as we generally prefer correct typography in user-facing strings. But I think that would be something for 6.0, to catch more instances and to minimize the number of string changes in a minor release.

[hellofromTonya]

@SergeyBiryukov Should the string being changed in this ticket be fixed now or bundled with a 6.0 fix?

[SergeyBiryukov]

There's at least one more string in the file that would need the same fix, so I'd say let's backport [52554] for now and open a new ticket for 6.0 to use ’ in all instances like this.

[audrasjb]

Alright, sounds good to me.

[hellofromTonya]

Cool. Can either of you please mark this ticket for dev-reviewed?

[hellofromTonya]

In 52559:

Editor: Fix enqueueing additional styles in wp_enqueue_block_style() to print only when blocks render.

In a block theme, additional block styles registered using the wp_enqueue_block_style function should only get printed when the block exists on a page. However, they currently always get
rendered.

This commit is a backport from Gutenberg that fixes the issue by printing the styles when a block
renders.

Follow-up to [52069].

Props poena, aristath, Mamaduka.
Merges [52556] to the 5.9 branch.
Fixes #54787.

[hellofromTonya]

I'm consistent. [52559] belongs with #54790, not this ticket :facepalm: (again).

[hellofromTonya]

In 52561:

Site Editor: Fix typo in home template translatable description.

The home template's description should be: "Displays as the site's home page, or as the Posts page when a static home page isn't set." This commit fixes the typo changing "it" to "isn't".

Follow-up to [52331].

Props kharisblank, talldanwp.
Merges [52554] to the 5.9 branch.
Fixes #54787.

Committed to trunk with https://core.trac.wordpress.org/changeset/52554 and to 5.9-branch with https://core.trac.wordpress.org/changeset/52561