Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54787 closed defect (bug) (fixed)

Typo for home template

Reported by: talldanwp's profile talldanwp Owned by: hellofromtonya's profile hellofromTonya
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: i18n-change has-patch dev-reviewed commit
Focuses: Cc:

Description (last modified by talldanwp)

Originally reported in Gutenberg - https://github.com/WordPress/gutenberg/issues/37841

To reproduce

  1. Visit the site editor
  2. Using the 'W' icon, open the sidebar
  3. Select 'Templates'
  4. Note that the description of the Home template has a typo ("it" at the end should be "isn't").

I'm unsure if this can be fixed for 5.9 as we're now in the hard string freeze phase. If not, we can punt to 5.9.1.

At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).

Change History (28)

This ticket was mentioned in PR #2136 on WordPress/wordpress-develop by talldan.


2 years ago
#1

See #54787, https://github.com/WordPress/gutenberg/pull/37843

Fixes a typo in the home template description. To test:

  1. Visit the site editor
  2. Using the 'W' icon, open the sidebar
  3. Select 'Templates'
  4. Note that the description of the Home template has a typo ("it" at the end should be "isn't").

#2 @talldanwp
2 years ago

  • Description modified (diff)

#3 @talldanwp
2 years ago

  • Owner set to talldanwp
  • Status changed from new to assigned

#4 in reply to: ↑ description @SergeyBiryukov
2 years ago

  • Keywords commit added

Replying to talldanwp:

At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).

Thanks for the ticket! I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.

#5 @swissspidy
2 years ago

  • Component changed from I18N to Editor

#6 @tobifjellner
2 years ago

It should be mentioned that up until about one year ago, the threshold for generation of language packs for core was 100%, any late string change might delay the generation of localized WordPress packs.

But now the thresholds are lowered a bit. In other words, a few late string changes may mean that an occasional untranslated string may show up in a localized package, but we can allow us to be a bit less nervous about breaking stuff.

I'd also like to mention that the original reporter was @kharisblank

#7 @hellofromTonya
2 years ago

The fix looks good to me and marking for commit.

What about the backport to 5.9 for RC2?

5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen.

Referencing @SergeyBiryukov's comment:

I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.

#8 @hellofromTonya
2 years ago

  • Owner changed from talldanwp to hellofromTonya
  • Status changed from assigned to reviewing

Self-assigning for commit to trunk.

#9 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52554:

Site Editor: Fix typo in home template translatable description.

The home template's description should be: "Displays as the site's home page, or as the Posts page when a static home page isn't set." This commit fixes the typo changing "it" to "isn't".

Follow-up to [52331].

Props kharisblank, talldanwp.
Fixes #54787.

#10 @hellofromTonya
2 years ago

  • Keywords dev-feedback added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for second committer review and opinion to backport to 5.9-branch.

As noted, 5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen. If yes, please mark as dev-reviewed.

#11 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52556:

Editor: Fix enqueueing additional styles in wp_enqueue_block_style() to print only when blocks render.

In a block theme, additional block styles registered using the wp_enqueue_block_style function should only get printed when the block exists on a page. However, they currently always get rendered.

This commit is a backport from Gutenberg that fixes the issue by printing the styles when a block renders.

Follow-up to [52069].

Props poena, aristath, Mamaduka.
Fixes #54787.

#12 @hellofromTonya
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Whoopsie, [52556] does not belong to this ticket. It belongs to #54790.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

#14 @SergeyBiryukov
2 years ago

  • Keywords dev-reviewed added; dev-feedback removed

[52554] looks good to backport.

#15 @audrasjb
2 years ago

  • Keywords dev-feedback added; dev-reviewed removed

Do we really need to use \ here?

#16 @audrasjb
2 years ago

We should use the ’ HTML entity.

#17 follow-up: @hellofromTonya
2 years ago

There are other cases of \' that should use the ’ HTML entity. Should those also be fixed? Or is fixing these as a group better for 5.9.1 given that 5.9 is in hard string freeze?

#18 in reply to: ↑ 17 @SergeyBiryukov
2 years ago

Replying to hellofromTonya:

There are other cases of \' that should use the ’ HTML entity. Should those also be fixed?

I'd say yes, as we generally prefer correct typography in user-facing strings. But I think that would be something for 6.0, to catch more instances and to minimize the number of string changes in a minor release.

#19 @hellofromTonya
2 years ago

@SergeyBiryukov Should the string being changed in this ticket be fixed now or bundled with a 6.0 fix?

#20 @SergeyBiryukov
2 years ago

There's at least one more string in the file that would need the same fix, so I'd say let's backport [52554] for now and open a new ticket for 6.0 to use ’ in all instances like this.

#21 @audrasjb
2 years ago

Alright, sounds good to me.

#22 @hellofromTonya
2 years ago

  • Keywords commit added

Cool. Can either of you please mark this ticket for dev-reviewed?

#23 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52559:

Editor: Fix enqueueing additional styles in wp_enqueue_block_style() to print only when blocks render.

In a block theme, additional block styles registered using the wp_enqueue_block_style function should only get printed when the block exists on a page. However, they currently always get
rendered.

This commit is a backport from Gutenberg that fixes the issue by printing the styles when a block
renders.

Follow-up to [52069].

Props poena, aristath, Mamaduka.
Merges [52556] to the 5.9 branch.
Fixes #54787.

#24 @hellofromTonya
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm consistent. [52559] belongs with #54790, not this ticket :facepalm: (again).

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

#26 @SergeyBiryukov
2 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#27 @hellofromTonya
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52561:

Site Editor: Fix typo in home template translatable description.

The home template's description should be: "Displays as the site's home page, or as the Posts page when a static home page isn't set." This commit fixes the typo changing "it" to "isn't".

Follow-up to [52331].

Props kharisblank, talldanwp.
Merges [52554] to the 5.9 branch.
Fixes #54787.

Note: See TracTickets for help on using tickets.