#54787 closed defect (bug) (fixed)
Typo for home template
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Editor | Keywords: | i18n-change has-patch dev-reviewed commit |
Focuses: | Cc: |
Description (last modified by )
Originally reported in Gutenberg - https://github.com/WordPress/gutenberg/issues/37841
To reproduce
- Visit the site editor
- Using the 'W' icon, open the sidebar
- Select 'Templates'
- Note that the description of the Home template has a typo ("it" at the end should be "isn't").
I'm unsure if this can be fixed for 5.9 as we're now in the hard string freeze phase. If not, we can punt to 5.9.1.
At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).
Change History (28)
This ticket was mentioned in PR #2136 on WordPress/wordpress-develop by talldan.
3 years ago
#1
#4
in reply to:
↑ description
@
3 years ago
- Keywords commit added
Replying to talldanwp:
At the same time this was flagged by a translator as being something difficult to translate, so fixing it might be be beneficial (https://wordpress.slack.com/archives/C02RP50LK/p1641807616022100).
Thanks for the ticket! I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.
#6
@
3 years ago
It should be mentioned that up until about one year ago, the threshold for generation of language packs for core was 100%, any late string change might delay the generation of localized WordPress packs.
But now the thresholds are lowered a bit. In other words, a few late string changes may mean that an occasional untranslated string may show up in a localized package, but we can allow us to be a bit less nervous about breaking stuff.
I'd also like to mention that the original reporter was @kharisblank
#7
@
3 years ago
The fix looks good to me and marking for commit.
What about the backport to 5.9 for RC2?
5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen.
Referencing @SergeyBiryukov's comment:
I think this can go into 5.9 to avoid any further confusion as more and more locales complete their translation.
#8
@
3 years ago
- Owner changed from talldanwp to hellofromTonya
- Status changed from assigned to reviewing
Self-assigning for commit to trunk.
#10
@
3 years ago
- Keywords dev-feedback added; commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for second committer review and opinion to backport to 5.9-branch.
As noted, 5.9 is in a hard string freeze. I defer to @SergeyBiryukov and others with more domain experience in i18n for hard string freeze for guidance on if the backport should happen. If yes, please mark as dev-reviewed
.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
#15
@
3 years ago
- Keywords dev-feedback added; dev-reviewed removed
Do we really need to use \
here?
#17
follow-up:
↓ 18
@
3 years ago
There are other cases of \'
that should use the ’
HTML entity. Should those also be fixed? Or is fixing these as a group better for 5.9.1 given that 5.9 is in hard string freeze?
#18
in reply to:
↑ 17
@
3 years ago
Replying to hellofromTonya:
There are other cases of
\'
that should use the’
HTML entity. Should those also be fixed?
I'd say yes, as we generally prefer correct typography in user-facing strings. But I think that would be something for 6.0, to catch more instances and to minimize the number of string changes in a minor release.
#19
@
3 years ago
@SergeyBiryukov Should the string being changed in this ticket be fixed now or bundled with a 6.0 fix?
#20
@
3 years ago
There's at least one more string in the file that would need the same fix, so I'd say let's backport [52554] for now and open a new ticket for 6.0 to use ’
in all instances like this.
#22
@
3 years ago
- Keywords commit added
Cool. Can either of you please mark this ticket for dev-reviewed
?
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
hellofromtonya commented on PR #2136:
3 years ago
#28
Committed to trunk with https://core.trac.wordpress.org/changeset/52554 and to 5.9-branch with https://core.trac.wordpress.org/changeset/52561
See #54787, https://github.com/WordPress/gutenberg/pull/37843
Fixes a typo in the home template description. To test: