Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#5479 closed defect (bug) (fixed)

Avoid infinite redirect

Reported by: ruckus Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch
Focuses: Cc:


In [6390] detecting infinite redirects is accidentally dropped due to wp_get_http_headers() being renamed to wp_get_http() but wp_get_http() still calling the former function (with extra arguments that are really intended for the latter).

The attached patch also restores the original two-argument calling convention for the compatibility version of wp_get_http_headers().

Attachments (2)

functions.diff (1.1 KB) - added by ruckus 8 years ago.
patch to wp-includes/functions.php
wp_get_http_redirect_fix-r6400.patch (836 bytes) - added by tellyworth 8 years ago.
patch fixed for GET case

Download all attachments as: .zip

Change History (6)

8 years ago

patch to wp-includes/functions.php

#1 @ruckus
8 years ago

  • Keywords has-patch added

#2 @ruckus
8 years ago

  • Cc ruckus added

8 years ago

patch fixed for GET case

#3 @tellyworth
8 years ago

Well spotted. The patch missed a spot though - redirection of a GET wasn't handled correctly. wp_get_http_redirect_fix-r6400.patch fixes both.

I added some extra unit test cases for the redirection limit and GET redirection, in TestHTTPFunctions:


#4 @ryan
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6402]) redirect fixes from ruckus and tellyworth. fixes #5479

Note: See TracTickets for help on using tickets.