WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #54798


Ignore:
Timestamp:
01/12/2022 07:00:56 PM (3 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #54798

    • Property Status changed from assigned to reviewing
    • Property Summary changed from Check for int in menu priority implementation to Check for int in menu priority
    • Property Owner set to audrasjb
    • Property Version changed from trunk to
    • Property Milestone changed from Awaiting Review to 6.0
    • Property Keywords has-patch has-unit-tests added

  • Ticket #54798 – Description

    initial v4  
    1 Similar to [https://core.trac.wordpress.org/ticket/48249], this ticket focuses on ensuring that devs don't accidentally pass non-integer values in the position argument.
     1Similar to #48249, this ticket focuses on ensuring that devs don't accidentally pass non-integer values in the position argument.
    22
    3 A similar issue was also reported in [https://core.trac.wordpress.org/ticket/40927], where passing a float argument in `add_menu_page` causes to override menu item.
     3A similar issue was also reported in #40927, where passing a float argument in `add_menu_page` causes to override menu item.
    44
    55For backward compatibility, I'd like to suggest informing users with `_doing_it_wrong` if a non-integer value is passed.