Main navigation move 'current' class declaration from <a> to <li>

[oaoao]

The format of the ul-based admin navigation puts the "current" class in the link itself:

<ul id="adminmenu">
<li><a href='themes.php'>Presentation</a></li>
<li><a href='options-general.php' class="current">Options</a></li>

This is bad, and makes styling difficult. It should be in the <li> element, as children can be targeted, but not parents.

<li class="current"><a href='options-general.php'>Options</a></li>

You can always target the link as before with

li.current a

And now you can also style the <li> element, as many tab-based CSS approaches require.

This requires a change in:
menu-header.php
wp-admin.css

[hempsworth]

Definitely agree with this, I was surprised to see the current method when I was making the patch for #5868

I'm going to make two patches, one which changes the position of [class="current"] just in the main navigation, and one which changes it for all of the navigation lists.

Ideally we want the latter, but I'm unsure as to whether it might break some plugins?

[hempsworth]

This changes the position of the classname just in the main navigation

[hempsworth]

This changes the position of the classname in all of the navigation menus

[hempsworth]

Oops, sorry about that!
Needs to be committed first :P

[ryan]

Patch breaks the fix for #5868. If we can fix that, I'm all for committing this.

[hempsworth]

Now works fine with #5868

[johnbillion]

Stale ticket.

(Quite funny to see how quaint the admin menu markup was 2 years ago...)