Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54811 closed defect (bug) (fixed)

Complete media url is not showing.

Reported by: sumitsingh's profile sumitsingh Owned by: joedolson's profile joedolson
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-screenshots has-patch commit
Focuses: ui, accessibility, css, administration Cc:

Description

Hi,

Complete media link not showing when I am on edit media page.

More information see SS.

Attachments (6)

Screenshot_2022-01-13-19-00-52-855_com.android.chrome.jpg (325.3 KB) - added by sumitsingh 2 years ago.
1st ss
Screenshot_2022-01-13-19-00-22-626_com.android.chrome.jpg (1.1 MB) - added by sumitsingh 2 years ago.
2nd ss
Screenshot_2022-01-13-19-05-27-776_com.android.chrome.jpg (282.6 KB) - added by sumitsingh 2 years ago.
Author name going right side
54811.diff (397 bytes) - added by sabernhardt 2 years ago.
Adding break-word styles for sample permalink (on Posts, Media or Comments) as well as setting to inline-block
54811.2.diff (550 bytes) - added by joedolson 2 years ago.
Remove padding on mobile
54811-alignment.png (11.5 KB) - added by joedolson 2 years ago.
Change of alignment for permalink

Download all attachments as: .zip

Change History (15)

@sumitsingh
2 years ago

Author name going right side

#1 @audrasjb
2 years ago

  • Focuses accessibility css removed
  • Keywords reporter-feedback added
  • Version 5.8.3 deleted

Hello and thank you for opening this ticket,

Do we really need to have this complete information? I don't really see the point of having all of this information displayed on the screen. In my opinion, all you need is to be able to easily copy paste this url.

Can you please detail the exact issue?

Thanks

(removing the version info since it wasn't added in 5.8.3)

#2 @joedolson
2 years ago

  • Milestone changed from Awaiting Review to 6.0
  • Owner set to joedolson
  • Status changed from new to accepted

Seeing the full url allows you to more easily differentiate between similar images, so it's definitely important information.

The url is the only piece of information in the screen that's 100% unique, so it's fairly important, even if much of the time it's not the primary reference point.

The username placement issue is separate, but also worth looking at.

#3 @joedolson
2 years ago

  • Focuses accessibility added

Also, it's triggering a horizontal scroll bar, which is an accessibility issue. Minor for this, yes, but still relevant.

@sabernhardt
2 years ago

Adding break-word styles for sample permalink (on Posts, Media or Comments) as well as setting to inline-block

#4 @sabernhardt
2 years ago

  • Component changed from Media to Posts, Post Types
  • Focuses css added
  • Keywords has-patch added; reporter-feedback removed

(The floating issue is on ticket #55508.)

I thought of creating a .break-word class for the permalink plus the Original file name (#55393) and any other elements that might need it.

On the other hand, I think the permalink could benefit from setting display to inline-block, which also would require a max-width.

@joedolson
2 years ago

Remove padding on mobile

@joedolson
2 years ago

Change of alignment for permalink

#5 @joedolson
2 years ago

I'm wondering if it makes sense to adjust the alignment on mobile; it's nominal, but it allos a bit more space for laying out the URL. Thoughts?

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


2 years ago

#7 @ryokuhi
2 years ago

As far as I can see, all other elements on the page have the same alignment, so the misaligned permalink pops up a bit. As such, for the sake of consistency, I think that the padding should be removed.
That said, this is not capital and, if the risk is that the patch doesn't make it in time for 6.0 Beta 1, let's leave the patch as is.

#8 @joedolson
2 years ago

  • Keywords commit added

I think that it's not crucial, and is unrelated to the issue in this ticket; so let's not implement design changes on a whim. It would also open the question of whether the alignment should also be changed on desktop, since that has the same indenting issue.

Marking for commit; use 54811.diff.

#9 @joedolson
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53114:

Posts, Post Types: Make permalink fully visible on mobile.

Set break-word on sample permalink so the full permalink will be visible on mobile devices in posts, media, and comments. Prevent hidden text overflow or horizontal scrolling on mobile.

Props sumitsingh, sabernhardt.
Fixes #54811.

Note: See TracTickets for help on using tickets.