Opened 2 years ago
Closed 14 months ago
#54813 closed defect (bug) (fixed)
Issue on mobile device in user listing page
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | 5.8.3 |
Component: | Users | Keywords: | has-screenshots has-patch needs-testing |
Focuses: | css, administration | Cc: |
Description
I think we need to space on both filters. More information see SS.
Attachments (9)
Change History (22)
This ticket was mentioned in PR #2163 on WordPress/wordpress-develop by shreyasikhar.
2 years ago
#2
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/54813
#4
@
23 months ago
- Milestone changed from Awaiting Review to 6.0
Thanks for the patch!
There still is a related issue with the item count overlapping the Change button at certain widths. I think I have seen that before on another ticket, but I am unable to find it now. (The overlap could be fixed separately.)
This ticket was mentioned in PR #3238 on WordPress/wordpress-develop by robinwpdeveloper.
15 months ago
#6
Fixes spacing issue between action buttons on Users list table page. Issue occurs on the mobile devices.
10px margin bottom added to match the bottom input and search spacing.
Trac ticket: 54813
robinwpdeveloper commented on PR #3238:
15 months ago
#7
Unwanted commits are pushed. So closing this one.
This ticket was mentioned in PR #3239 on WordPress/wordpress-develop by robinwpdeveloper.
15 months ago
#8
Fixes spacing issue between action buttons on Users list table page. Issue occurs on the mobile devices.
10px margin bottom added to match the bottom input and search spacing.
Trac ticket: 54813
This ticket was mentioned in Slack in #core by robinwpdeveloper. View the logs.
15 months ago
@
15 months ago
adding a small bottom margin to the select
element could help with certain languages on small screens (54813.2.diff)
#10
@
15 months ago
PR 3239 is a viable option; I agree that the distance between these controls should be (at least) as much as the distance between the User search input and its button.
However, I suggest using 54813.2.diff to fix the absolute positioning overlap, together with the margin fix. It clears the float on the second .actions
element and only adds a margin on that. For languages with wider controls, the patch includes a bottom margin for the select
elements in case the button wraps to the next line on small screens, to give a little space for focus outlines.
Both patch options increase empty space before the Search on other list tables screens: 10 pixels with the PR, 15 pixels with the .diff patch. (The second .actions
element has no content on those screens, but it is not exactly empty to use the CSS :empty
in 54813.2.diff.)
Button Issue ss