Hide "view" link from Media Library List Mode if empty string passed to attachment_link

[oh_hello]

As of WP 5.6.0, an empty string can be passed to attachment_link which will disable the view attachment page link on the media modal. That's great. Ref: ​https://developer.wordpress.org/reference/hooks/attachment_link/.

However, there's another link that should also be disabled in this scenario.

That's the "View" link that appears when hovering over a media item when browsing the Media Library in "List Mode" instead of "Grid Mode".

Currently, that "View" link is just empty. The code generated is:

<a href="" aria-label="View “title of media item”" rel="bookmark">View</a>

Ideally that "View" link would be removed entirely.

[oh_hello]

Screenshot of the "view" link being referenced.

[iqbalrony]

Here is the patch with the fixed code.

[iqbalrony]

Here is the patch with the fixed code.

[joedolson]

Tested by adding filter

add_filter( 'attachment_link', function() use ($link) {
     return '';
});

Before patch: view link present, empty URL.

After patch: no view link.

Screenshots coming.

[joedolson]

Before patch: view link, empty href.

[joedolson]

No view link after patch

Test changes to remove list table link when attachment link is filter to empty value.

Trac ticket: https://core.trac.wordpress.org/ticket/54824

Fixed in https://core.trac.wordpress.org/ticket/54824

That's https://core.trac.wordpress.org/changeset/55218

[joedolson]

This was closed in r55218, but didn't get auto-closed.

Media: Hide 'view' link if empty string passed to attachment_link.

Fix empty href attribute on 'View' link when the attachment_link filter is used to hide attachment pages.

Props oh_hello, iqbalrony.
Fixes #54824.