Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54831 closed enhancement (fixed)

Docs: Replace Current theme with Active theme in various DocBlocks

Reported by: audrasjb's profile audrasjb Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: docs Cc:

Description

After [52580], it would be nice to also update various Docblocks to replace "Current Theme" with "Active Theme".

Follow-up to [52580].
See #54770.

Change History (8)

This ticket was mentioned in PR #2174 on WordPress/wordpress-develop by audrasjb.


2 years ago
#1

  • Keywords has-patch added

#2 @audrasjb
2 years ago

  • Keywords dev-feedback 2nd-opinion added
  • Type changed from defect (bug) to enhancement

#3 @Presskopp
2 years ago

I give to consider that we also have lots of references to "current theme" like on

https://developer.wordpress.org/reference/functions/get_template_directory/

and we have functions in core: current_theme(), current_theme_supports(), validate_current_theme()

and some usages of

$current_theme_data and 'current_theme_has_errors'

Do they all need to be renamed?

#4 @audrasjb
2 years ago

Good point @Presskopp. For me, this ticket only aims to take care of the Docblocks occurrences, as their content is publicly displayed on HelpHub.

Once this is eventually merged into core, we can open another ticket to address variable naming.

And ultimately, maybe deprecate some functions and hooks, but that's the most difficult part as it introduces breaking changes :)

#5 @audrasjb
2 years ago

  • Keywords dev-feedback 2nd-opinion removed

Thanks for the review @costdev 🙂
I think we're good to go 👍

#6 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Status changed from new to assigned

#7 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52610:

Docs: Replace "Current theme" with "Active theme" in various DocBlocks.

This change replaces "Current theme" with "Active theme" in various DocBlocks for better consistency with user-facing strings.

Follow-up to [52580].

Props Presskopp, audrasjb, costdev.
Fixes #54831.
See #54770.

Note: See TracTickets for help on using tickets.