Change History (9)
This ticket was mentioned in PR #2174 on WordPress/wordpress-develop by audrasjb.
5 years ago
#1
- Keywords has-patch added
#3
@
5 years ago
I give to consider that we also have lots of references to "current theme" like on
https://developer.wordpress.org/reference/functions/get_template_directory/
and we have functions in core: current_theme(), current_theme_supports(), validate_current_theme()
and some usages of
$current_theme_data and 'current_theme_has_errors'
Do they all need to be renamed?
#4
@
5 years ago
Good point @Presskopp. For me, this ticket only aims to take care of the Docblocks occurrences, as their content is publicly displayed on HelpHub.
Once this is eventually merged into core, we can open another ticket to address variable naming.
And ultimately, maybe deprecate some functions and hooks, but that's the most difficult part as it introduces breaking changes :)
#5
@
5 years ago
- Keywords dev-feedback 2nd-opinion removed
Thanks for the review @costdev 🙂
I think we're good to go 👍
5 years ago
#8
Committed in https://core.trac.wordpress.org/changeset/52610
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Trac ticket: https://core.trac.wordpress.org/ticket/54831