WordPress.org
Get WordPress

Make WordPress Core

Opened 17 months ago

Last modified 11 days ago

#54839 new defect (bug)

Image upload after dirty filter requires filter change before it can be inserted to page

Reported by: utkarshpatel's profile utkarshpatel Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch has-testing-info
Focuses: ui, javascript Cc:

Description

Steps:

  1. Open media library popup.
  2. Change date filter.
  3. Upload new image.
  4. See uploaded image is not visible in list nor selectable. (Select button is disabled)
  5. Change filter to match the new image uploaded, See image is visible.

Expected behavior:

  1. Uploaded image should be selectable if it matches filter (or should reset filter on tab change).

Current behavior:

  1. Uploaded image after dirty filter is not selectable.

Attachments (1)

media-filter-bug-encoded.mp4​ (2.0 MB) - added by utkarshpatel 17 months ago.
Screencast demonstrating bug

Download all attachments as: .zip

Change History (17)

@utkarshpatel
17 months ago

Screencast demonstrating bug

#1 @hellofromTonya
17 months ago

  • Milestone changed from Awaiting Review to 6.0
  • Version trunk deleted

Hello @utkarshpatel,

Welcome back to WordPress Core's Trac 👋 Thank you for reporting this issue!

I can reproduce the issue on trunk, 5.8.3, and 5.5.8 (stopped testing at this point release). Investigation will be needed to identify when the bug was introduced and root cause. As I can reproduce, pulling it into the 6.0 milestone for further investigation.

As this is not due to 5.9, removing trunk as the Version. Once the version is identified, please update.

#2 @utkarshpatel
16 months ago

Hello @hellofromTonya,

Thank you!

I was able to reproduce the issue for version 5.0 - 5.4. This was introduced in 5.0 and 4.9 handles this correctly.

I will work on the patch.

#3 @utkarshpatel
16 months ago

Wrong test - was able to reproduce in WP version 4.6 - 5.4 as well.

This ticket was mentioned in ​Slack in #core by costdev. ​View the logs.
14 months ago

#5 @costdev
14 months ago

  • Keywords needs-patch has-testing-info added
  • Milestone changed from 6.0 to 6.1
  • Summary changed from Image upload after dirty filter requires filter change before it cab be inserted to page to Image upload after dirty filter requires filter change before it can be inserted to page

After the discussion in the bug scrub, I'm moving this ticket to the 6.1 milestone, adding the needs-patch and has-testing-info keywords, and correcting a minor typo in the ticket title.

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs.
10 months ago

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs.
9 months ago

#8 @antpb
9 months ago

  • Milestone changed from 6.1 to 6.2

This one still needs a patch so might be better suited for 6.2. Moving to the next milestone but feel free to move it back if anyone has the bandwidth to make it happen for 6.1!

#9 @Mista-Flo
4 months ago

This is a tough one, the backbone app is quite hard to navigate, @adamsilverstein might be able to give some guidance here.

I tried to investigate but I'm a bit rusty inside the Media Library code to be honest.

#10 @adeltahri
4 months ago

I was able to reproduce the issue for the version of WordPress 6.2-alpha-54642

This ticket was mentioned in ​Slack in #core-media by antpb. ​View the logs.
4 months ago

#12 @antpb
4 months ago

This is looking too much to land in 6.2 so we should move it to 6.3 asap.

#13 @sabernhardt
4 months ago

  • Milestone changed from 6.2 to 6.3

#14 @oglekler
12 days ago

  • Focuses ui javascript added

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.
11 days ago

#16 @oglekler
11 days ago

This ticket was discussed during the bug scrub. To help pinpoint the bug we agreed to check when this bug was firstly introduced.

Additional props: @mukesh27 @costdev

Note: See TracTickets for help on using tickets.