Add end to end test case for Trash a single post and restore post from trash

[pavanpatil1]

Add two new test cases in wpe2e for the trash a single post and restore post from the trash.

This ticket is to add an E2E test for this feature

Trac ticket: https://core.trac.wordpress.org/ticket/54843

Trac ticket: https://core.trac.wordpress.org/ticket/54843

Hello @pooja-muchandikar,

Here are a few things that I noticed and that could be improved in your PR:

• Test files end with .test.js, so your test file would become restore-trash-post.test.js
• loginUser() is not used in the tests, so it can be removed from the imports
• It is a good idea to remove all posts before your tests (see ​https://github.com/WordPress/wordpress-develop/blob/371966a187081662c155ef98ddb7a681dc10f268/tests/e2e/specs/edit-posts.test.js#L10-L12 for example)

@pooja-muchandikar thanks for adding the updates. Your tests are very clean and they all pass. Here is something that we could improve.

• Here ​https://github.com/pooja-muchandikar/wordpress-develop/blob/c8e28fc74f1d074f46caa7849796490b1743cd2a/tests/e2e/specs/empty-trash-posts.test.js#L40:

It might make sense to assert the message that appears when the post is trashed. In this case, it'll be "1 post permanently deleted."
That will help in case the trashing steps outputs an error. By asserting the success message, we make sure that we have the expected behavior.

Except the above comment, the PR looks fine to me.

@tellthemachines @hellofromtonya you might want to give a look, before we move to merging it.

Hi @JustinyAhin,

Previously, assertion message was only added, but while running the test cases CI was failing, as the number of posts were getting deleting dynamically, that's the reason changed the selector.

​https://github.com/WordPress/wordpress-develop/pull/2186/commits/3b817af66d229507042706bb9125274a5d07823f#diff-3860c93f38e576535aad8fdbb45ee1be20e197c829f616f26609cfb253910d6eL47

Hi @JustinyAhin, @hellofromtonya

I hope you are doing well!

Wanted to know if there is any update on this? Do I need to make the changes or can we proceed further?

​https://github.com/WordPress/wordpress-develop/pull/2186#issuecomment-1041162514

@tellthemachines @hellofromtonya you might want to give a look, before we move to merging it.

Hello @pooja-muchandikar, the PR is fine for me. Can you bring it up during the next Test team meeting on Thursday, so it can be reviewed by a committer?

Sure
Thanks!

Hi @kevin940726,

I have addressed all the feedbacks shared by you and also combined the test cases, please take a look.

Thanks!

Hi @kevin940726,

Made all necessary changes and also commented on respective feedbacks with reasoning. Also tried to work on few indention changes please take a look.

Thanks!

Hi @kevin940726,

I hope you are doing well! Just checking if you checked latest commits on this PR.

[hellofromTonya]

​PR 2186 has been approved by @kevin940726 (Thank you Kai!). Marking for commit. Prepping commit now.

[hellofromTonya]

In 52839:

Build/Test Tools: Add trash and restore of a single post e2e tests.

Adds an end-to-end (e2e) test case for:

• Emptying a post from the trash.
• Restoring a post from the trash.

Props pavanpatil1, pooja1210, justinahinon, kevin940726.
Fixes #54843.

Committed via changeset https://core.trac.wordpress.org/changeset/52839. Thank you @pooja-muchandikar @JustinyAhin @kevin940726 for your contributions ⭐