Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#54855 closed enhancement (fixed)

Ui issue on edit menu page

Reported by: sumitsingh's profile sumitsingh Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.8.3
Component: Menus Keywords: has-screenshots good-first-bug has-patch commit
Focuses: ui, css, administration Cc:

Description

H,

UI issue in edit menu page on admin side on bulk checkbox button.

More information check SS.

Attachments (5)

Screenshot_2022-01-17-23-49-22-090_com.android.chrome.2.jpg (268.9 KB) - added by sumitsingh 3 years ago.
Bulk Button Issue ss
Screenshot_2022-01-17-23-49-06-564_com.android.chrome.jpg (292.1 KB) - added by sumitsingh 3 years ago.
Bulk Button Issue ss1
54855.diff (940 bytes) - added by priyank9033 3 years ago.
Added padding to resolve the issue of the menu in the mobile device.
Capture d’écran 2022-03-21 à 11.10.22.png (98.0 KB) - added by audrasjb 3 years ago.
Before patch
Capture d’écran 2022-03-21 à 11.09.51.png (92.1 KB) - added by audrasjb 3 years ago.
After patch: better padding for bulk actions label

Download all attachments as: .zip

Change History (19)

#1 @sabernhardt
3 years ago

  • Focuses css added
  • Keywords needs-patch added

This isn't exactly broken, but a small padding on the top and bottom probably would improve the button label:

@media screen and (max-width: 782px) {
	.bulk-select-button {
		padding: 5px 10px;
	}
}

#2 @sabernhardt
3 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


3 years ago

#4 @ryokuhi
3 years ago

  • Focuses accessibility removed
  • Keywords good-first-bug added

This ticket was reviewed today during the Accessibility Team's bug-scrub.

While the Bulk Select feature was added to improve accessibility, this doesn't seem to be an accessibility issue and, as such, I'm removing the focus.

As @sabernhardt already suggested a possible solution, we're adding the good-first-bug label, so that a new contributor willing to help to WordPress will have an easy enough task to complete.

@priyank9033
3 years ago

Added padding to resolve the issue of the menu in the mobile device.

#5 @sabernhardt
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 6.0

#6 @audrasjb
3 years ago

  • Keywords needs-refresh added

Adding needs-refresh keyword as the above patch doesn't meet WordPress Coding Standards

#7 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #slackhelp by priyank9033. View the logs.


3 years ago

#9 @pbiron
3 years ago

@priyank9033 I see 3 WPCS problems with the patch, all easy to fix:

  1. remove the space before the semi-colon in margin: calc( 1em + 9px ) 0 ;
  2. remove the blank line before #nav-menu-footer {
  3. add a space after the colon in padding:5px 10px;

This ticket was mentioned in PR #2438 on WordPress/wordpress-develop by audrasjb.


3 years ago
#10

  • Keywords needs-refresh removed

@audrasjb
3 years ago

After patch: better padding for bulk actions label

#11 @audrasjb
3 years ago

  • Status changed from reviewing to accepted

Patch looks good to go. Committing right now.

#12 @audrasjb
3 years ago

  • Keywords commit added

#13 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52971:

Menus: Improve padding on bulk action labels for small screens.

Props sumitsingh, sabernhardt, ryokuhi, priyank9033, audrasjb, pbiron.
Fixes #54855.

Note: See TracTickets for help on using tickets.