#54855 closed enhancement (fixed)
Ui issue on edit menu page
Reported by: | sumitsingh | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | normal | Version: | 5.8.3 |
Component: | Menus | Keywords: | has-screenshots good-first-bug has-patch commit |
Focuses: | ui, css, administration | Cc: |
Description
H,
UI issue in edit menu page on admin side on bulk checkbox button.
More information check SS.
Attachments (5)
Change History (19)
#1
@
3 years ago
- Focuses css added
- Keywords needs-patch added
This isn't exactly broken, but a small padding on the top and bottom probably would improve the button label:
@media screen and (max-width: 782px) { .bulk-select-button { padding: 5px 10px; } }
This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.
3 years ago
#4
@
3 years ago
- Focuses accessibility removed
- Keywords good-first-bug added
This ticket was reviewed today during the Accessibility Team's bug-scrub.
While the Bulk Select feature was added to improve accessibility, this doesn't seem to be an accessibility issue and, as such, I'm removing the focus.
As @sabernhardt already suggested a possible solution, we're adding the good-first-bug label, so that a new contributor willing to help to WordPress will have an easy enough task to complete.
#5
@
3 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 6.0
#6
@
3 years ago
- Keywords needs-refresh added
Adding needs-refresh
keyword as the above patch doesn't meet WordPress Coding Standards
This ticket was mentioned in Slack in #slackhelp by priyank9033. View the logs.
3 years ago
#9
@
3 years ago
@priyank9033 I see 3 WPCS problems with the patch, all easy to fix:
- remove the space before the semi-colon in
margin: calc( 1em + 9px ) 0 ;
- remove the blank line before
#nav-menu-footer {
- add a space after the colon in
padding:5px 10px;
This ticket was mentioned in PR #2438 on WordPress/wordpress-develop by audrasjb.
3 years ago
#10
- Keywords needs-refresh removed
Trac ticket: https://core.trac.wordpress.org/ticket/54855
#11
@
3 years ago
- Status changed from reviewing to accepted
Patch looks good to go. Committing right now.
3 years ago
#14
Committed in https://core.trac.wordpress.org/changeset/52971
Bulk Button Issue ss