WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #54858, comment 2


Ignore:
Timestamp:
01/19/2022 11:44:43 AM (4 years ago)
Author:
arthur791004
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #54858, comment 2

    v1 v2  
    1 Oh, I'm sorry for mistyping. It should be `language` property in our use case. See   https://github.com/Automattic/wp-calypso/blob/94fe59f75d919c439f182764eed7d86f1f63da48/packages/i18n-utils/src/locale-context.tsx#L41. The language property comes from the translation json file and we will try to get the language property from the domain configuration but it might be undefined. But what I want to say is that the property in the domain configuration might be overridden and become undefined.
     1Oh, I'm sorry for mistyping. It should be `language` property in our use case. See   https://github.com/Automattic/wp-calypso/blob/94fe59f75d919c439f182764eed7d86f1f63da48/packages/i18n-utils/src/locale-context.tsx#L41. The language property comes from the translation json file and we will try to get the language property from the domain configuration but it might be `undefined`. But what I want to say is that the property in the domain configuration might be overridden and become `undefined` if we use `setLocaleData` function.
    22