Opened 5 years ago
Last modified 2 months ago
#54892 new enhancement
E2E tests for Creating Menu, Removing existing menu and Remove items from Menu
| Reported by: | pooja1210 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-patch has-unit-tests |
| Cc: | Focuses: |
Description
Add three new test cases in WP-e2e:
- Create a New Menu
- Removing Existing Menu
- Remove Items from the Menu
This ticket is to add E2E test for this feature.
Change History (5)
This ticket was mentioned in PR #2338 on WordPress/wordpress-develop by pavanpatil1.
5 years ago
#1
- Keywords has-patch added
pavanpatil1 commented on PR #2338:
5 years ago
#2
Hi @JustinyAhin, I hope you are doing well!.
Thank you so much for reviewing the PR. I have addressed all the shared feedbacks. Could you please take a look at it again?
pavanpatil1 commented on PR #2338:
5 years ago
#3
Hi @JustinyAhin @hellofromtonya,
I hope you are doing well! Wanted to know if there is any update on this? Do I need to make the changes or can we proceed further?
This ticket was mentioned in PR #12669 on WordPress/wordpress-develop by @csmcneill.
3 months ago
#4
- Keywords has-unit-tests added
Adds end-to-end coverage for classic menu management on nav-menus.php: creating a menu, adding a custom link, assigning a theme location, and deleting a menu.
https://core.trac.wordpress.org/ticket/54892 proposed exactly this coverage in 2022; its PR (#2338) predates the Playwright migration and has bit-rotted. This is a fresh implementation against the current utils and markup.
One deliberate choice: menu controls are activated via keyboard (focus + Enter) rather than pointer clicks. The sticky footer on nav-menus.php can shift on focus and silently swallow the first pointer click at certain window heights — reported separately as https://core.trac.wordpress.org/ticket/65684, with a community patch in progress for 7.2. Keyboard activation is immune, and the comments in the spec document the routing so the workaround can be dropped once #65684 lands.
Trac ticket: https://core.trac.wordpress.org/ticket/54892 (see also https://core.trac.wordpress.org/ticket/52895)
## Verification
- Passes in this repository's local Docker environment against trunk (repeated runs).
- Also verified against WordPress 7.0.2 and 7.1-beta3 installs (wp-env) as part of a legacy-surface regression-testing effort for 7.1.
## Use of AI Tools
AI assistance: Yes
Tool(s): Claude (Claude Code via Craft Agents)
Agent(s): Fable 5
Used for: Test authoring and cross-environment verification, with human review; reviewed and submitted by the author.
#5
@
2 months ago
A fresh implementation of this coverage is open as https://github.com/WordPress/wordpress-develop/pull/12669 — the earlier https://github.com/WordPress/wordpress-develop/pull/2338 predates the Playwright migration and has bit-rotted. 12669 covers creating a menu, adding a custom link, assigning a theme location, and deleting a menu. Menu controls are activated via keyboard rather than pointer clicks to stay clear of the sticky-footer click loss reported in #65684; the spec documents that routing so the workaround can be dropped once #65684 lands. Green across the full CI matrix.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Trac ticket: https://core.trac.wordpress.org/ticket/54892