WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#54908 closed defect (bug) (fixed)

Standard post type UI is exposed for templates and template parts

Reported by: manfcarlo Owned by: audrasjb
Priority: normal Milestone: 5.9.1
Component: Editor Version:
Severity: normal Keywords: has-patch fixed-major
Cc: Focuses:

Description

In [52158] the standard post type UI was added back for templates and template parts, because these features had been temporarily removed from the site editor in the rush to get 5.9 ready for December. Since 5.9 was delayed and these features were properly added back to the site editor, the show_ui values for these post types should be returned back to false, as was recommended in ​this comment.

Change History (10)

#1 @SergeyBiryukov
5 years ago

  • Component General → Editor
  • Milestone Awaiting Review → 5.9.1

This ticket was mentioned in ​PR #2258 on ​WordPress/wordpress-develop by ​audrasjb.
5 years ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54908

#3 @audrasjb
5 years ago

  • Owner set to audrasjb
  • Status new → accepted

Thanks for opening a ticket for this. The above PR fixes the issue.

Last edited 5 years ago by audrasjb (previous) (diff)

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
5 years ago

#5 @audrasjb
5 years ago

  • Resolution → fixed
  • Status accepted → closed

Fixed in https://core.trac.wordpress.org/changeset/52668

#6 @audrasjb
5 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for backport.

#8 @Boniu91
5 years ago

  • Keywords needs-testing-info added

#9 @audrasjb
5 years ago

  • Keywords needs-testing-info removed

Removing needs-testing-info since this change has already been committed in [52668].
Next step is to backport this to 5.9.

#10 @audrasjb
4 years ago

  • Resolution → fixed
  • Status reopened → closed

In 52712:

Editor: Remove standard post type UI for templates and template parts.

In [52158] the standard post type UI was added back for templates and template parts, because these features had been temporarily removed from the site editor in the rush to get 5.9 ready for December. Since 5.9 these features were properly added back to the site editor, the show_ui values for these post types should be returned back to false.

Follow-up to [52158].

Props manfcarlo, audrasjb.
Merges [52668] to the 5.9 branch.
Fixes #54908.

Note: See TracTickets for help on using tickets.