WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54908 closed defect (bug) (fixed)

Standard post type UI is exposed for templates and template parts

Reported by: manfcarlo's profile manfcarlo Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch fixed-major
Focuses: Cc:

Description

In [52158] the standard post type UI was added back for templates and template parts, because these features had been temporarily removed from the site editor in the rush to get 5.9 ready for December. Since 5.9 was delayed and these features were properly added back to the site editor, the show_ui values for these post types should be returned back to false, as was recommended in ​this comment.

Change History (10)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Editor
  • Milestone changed from Awaiting Review to 5.9.1

This ticket was mentioned in ​PR #2258 on ​WordPress/wordpress-develop by ​audrasjb.
3 years ago #2

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54908

#3 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for opening a ticket for this. The above PR fixes the issue.

Last edited 3 years ago by audrasjb (previous) (diff)

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#5 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in https://core.trac.wordpress.org/changeset/52668

#6 @audrasjb
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#8 @Boniu91
3 years ago

  • Keywords needs-testing-info added

#9 @audrasjb
3 years ago

  • Keywords needs-testing-info removed

Removing needs-testing-info since this change has already been committed in [52668].
Next step is to backport this to 5.9.

#10 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52712:

Editor: Remove standard post type UI for templates and template parts.

In [52158] the standard post type UI was added back for templates and template parts, because these features had been temporarily removed from the site editor in the rush to get 5.9 ready for December. Since 5.9 these features were properly added back to the site editor, the show_ui values for these post types should be returned back to false.

Follow-up to [52158].

Props manfcarlo, audrasjb.
Merges [52668] to the 5.9 branch.
Fixes #54908.

Note: See TracTickets for help on using tickets.