WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#5491 closed defect (bug) (fixed)

When `tags-input` field, incomplete tags are autosaved

Reported by: xknown Owned by: ryan
Milestone: Priority: low
Severity: normal Version: 2.3.1
Component: General Keywords:
Focuses: Cc:

Description (last modified by lloydbudd)

Autosave should be disabled while tags-input field has the focus -- incomplete tags are saved when autosave interval is reached.

Proposed solution: Autosave should be disabled if tags-input field has the focus

Attachments (2)

autosave.diff (2.5 KB) - added by xknown 6 years ago.
autosave.2.diff (2.5 KB) - added by xknown 6 years ago.
Save tags only if tags-input doesn't have the focus

Download all attachments as: .zip

Change History (9)

xknown6 years ago

comment:1 lloydbudd6 years ago

Bug introduced in #5359 [6373]

comment:2 lloydbudd6 years ago

  • Description modified (diff)
  • Summary changed from Autosave should be disabled if tags-input field has the focus to When `tags-input` field, incomplete tags are autosaved

xknown, please try to set the Summary to describe the symptom, not a solution.

I guess a more robust solution isn't feasible, like only autosave all other properties if tags-input field is in focus?

comment:3 xknown6 years ago

Lloyd: I'm sorry about the Summary. I'll upload a new patch.

xknown6 years ago

Save tags only if tags-input doesn't have the focus

comment:4 lloydbudd6 years ago

xknown, no problem at all. You are such a fantastic contributor, I really wouldn't care if you tickets were just patches, no text at all -- ok, please, please don't do that.

comment:5 ryan6 years ago

  • Owner changed from anonymous to ryan

comment:6 Nazgul6 years ago

  • Keywords needs-patch added

Patch is stale

comment:7 janbrasna5 years ago

  • Cc janbrasna added
  • Keywords needs-patch removed
  • Milestone 2.9 deleted
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [6542] thanks to the new tag entry system.

Note: See TracTickets for help on using tickets.