#54917 closed enhancement (duplicate)
Block template - missed check for support
Reported by: | madeinua | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | minor | Version: | 5.9 |
Component: | Themes | Keywords: | has-patch has-unit-tests |
Focuses: | template | Cc: |
Description
I suppose this part is missed at the beginning of locate_block_template():
if ( ! current_theme_supports( 'block-templates' ) ) { return $template; }
Attachments (2)
Change History (15)
This ticket was mentioned in PR #2246 on WordPress/wordpress-develop by kapilpaul.
3 years ago
#3
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/54917
#4
@
3 years ago
Hi @kapilpaul, thanks for the patch!
The tests on PR 2246 are failing because block-templates
support is not added until the setup_theme
action has run. I've commented on the PR to request a change that will fix the tests so that this fix can be considered for commit
.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
This ticket was mentioned in Slack in #core by rafiahmedd. View the logs.
3 years ago
This ticket was mentioned in Slack in #core by costdev. View the logs.
3 years ago
This ticket was mentioned in PR #2290 on WordPress/wordpress-develop by rafiahmedd.
3 years ago
#8
- Keywords has-unit-tests added
Trac ticket: https://core.trac.wordpress.org/ticket/54917
This ticket was mentioned in Slack in #core by rafiahmedd. View the logs.
3 years ago
kapilpaul commented on PR #2246:
3 years ago
#10
@costdev Thanks for reviewing it. updated the test case as you mentioned.
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
#12
@
3 years ago
- Milestone 5.9.1 deleted
- Resolution set to duplicate
- Status changed from new to closed
Closing in favor of #54844.
See this comment: https://core.trac.wordpress.org/ticket/54844#comment:18
3 years ago
#13
Committed in https://core.trac.wordpress.org/changeset/52697
Related: #54844