Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#54919 closed defect (bug) (duplicate)

Twenty Twenty: Bug in button outlines on WP 5.9

Reported by: dhjw's profile dhjw Owned by:
Milestone: Priority: normal
Severity: major Version: 5.9
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Attachments (2)

55006.patch (578 bytes) - added by umesh84 3 years ago.
added patch
54919.patch (452 bytes) - added by umesh84 3 years ago.
added new patch

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
3 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Bug in button outlines in twentytwenty on WP 5.9 to Twenty Twenty: Bug in button outlines on WP 5.9

@umesh84
3 years ago

added patch

@umesh84
3 years ago

added new patch

#3 @dhjw
3 years ago

Hi, the patch seemed to fail on my v1.9 twentytwenty. Also, I'm new here and ignorantly added the needs-patch tag. Would a pull request be more appropriate so the fix is actually applied to future versions and can someone do it? Thanks

Edit: Okay I think I got the pull request done. Thanks for help with the fix.

Last edited 3 years ago by dhjw (previous) (diff)

This ticket was mentioned in PR #2284 on WordPress/wordpress-develop by dhjw.


3 years ago
#4

  • Keywords has-patch added; needs-patch removed

Fix button outlines for WP 5.9

Trac ticket: https://core.trac.wordpress.org/ticket/54919

This ticket was mentioned in PR #2285 on WordPress/wordpress-develop by dhjw.


3 years ago
#5

Fix button outlines for WP 5.9 (TwentyFifteen)
Trac ticket: https://core.trac.wordpress.org/ticket/54919

#6 @dhjw
3 years ago

̶S̶o̶r̶r̶y̶ ̶I̶ ̶d̶i̶d̶n̶'̶t̶ ̶p̶r̶e̶f̶i̶x̶ ̶t̶h̶e̶ ̶p̶u̶l̶l̶ ̶r̶e̶q̶u̶e̶s̶t̶s̶ ̶p̶r̶o̶p̶e̶r̶l̶y̶ ̶w̶i̶t̶h̶ ̶T̶w̶e̶n̶t̶y̶ ̶T̶w̶e̶n̶t̶y̶:̶ ̶a̶n̶d̶ ̶T̶w̶e̶n̶t̶y̶ ̶F̶i̶f̶t̶e̶e̶n̶:̶ ̶s̶h̶o̶u̶l̶d̶ ̶i̶ ̶r̶e̶d̶o̶ ̶t̶h̶e̶m̶?̶ ̶

Last edited 2 years ago by dhjw (previous) (diff)

#7 @sabernhardt
2 years ago

  • Focuses css added
  • Keywords needs-design removed
  • Milestone Awaiting Review deleted

Thanks for the report and patches/pull requests!

Unfortunately I noticed ticket:55824 first, and now it has more discussion. I'll close this ticket to keep future activity in one place. If you have anything to add, please comment there.

Also, Twenty Fifteen's ticket is #55006. Its patch should work on "button" links in widget areas as well as within the post .entry-content.

#8 @sabernhardt
2 years ago

If you ever want to change the title to a pull request, you should have an "Edit" button next to the title on the GitHub page for the PR. I did not need to re-submit one of my pull requests after updating its title for the Pull Requests section of the ticket to update.

#9 @sabernhardt
2 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #55824.

Note: See TracTickets for help on using tickets.