Context Navigation

← Previous Ticket
Next Ticket →

#54928 closed defect (bug) (fixed)

Twenty Twenty-Two: 404 search label should be translated

Reported by:	kjellr	Owned by:	audrasjb
Priority:	normal	Milestone:	5.9.1
Component:	Bundled Theme	Version:	5.9
Severity:	normal	Keywords:	has-patch commit fixed-major
Cc:		Focuses:

Description

The hidden-404 pattern contains a label that is not marked for translation. We should update this in core after 5.9 is released and mark it for inclusion in 5.9.1.

https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwentytwo/inc/patterns/hidden-404.php#L14

---

Originally reported by @jffng over on GitHub:
https://github.com/WordPress/twentytwentytwo/issues/342

Change History (8)

This ticket was mentioned in PR #2257 on WordPress/wordpress-develop by walbo.

4 years ago #1

Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/54928

#2 @audrasjb
4 years ago

Keywords commit added
Owner set to audrasjb
Status new → accepted

The proposed PR looks good to me and fixes the issue. Marking for commit.

#3 @SergeyBiryukov
4 years ago

Summary [Twenty Twenty-Two] 404 search label should be translated → Twenty Twenty-Two: 404 search label should be translated

This ticket was mentioned in Slack in #core by audrasjb. View the logs.

4 years ago

#5 @audrasjb
4 years ago

Resolution → fixed
Status accepted → closed

In 52664:

Twenty Twenty-Two: Make 404 pattern search label and button translatable.

This changes makes the Twenty Twenty-Two "hidden-404" pattern fully prepared for translation.

Props kjellr, walbo.
Fixes #54928.

audrasjb commented on PR #2257:

4 years ago #6

Committed in https://core.trac.wordpress.org/changeset/52664

#7 @audrasjb
4 years ago

Keywords fixed-major added
Resolution fixed
Status closed → reopened

Reopening for backport consideration.

#8 @peterwilsoncc
4 years ago

Resolution → fixed
Status reopened → closed

In 52666:

Twenty Twenty-Two: Make 404 pattern search label and button translatable.

This changes makes the Twenty Twenty-Two "hidden-404" pattern fully prepared for translation.

Props kjellr, walbo, audrasjb.
Merges [52664] to the 5.9 branch.
Fixes #54928.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#54928 closed defect (bug) (fixed)

Twenty Twenty-Two: 404 search label should be translated

Description

Change History (8)

This ticket was mentioned in ​PR #2257 on ​WordPress/wordpress-develop by ​walbo. 4 years ago #1

#2 @audrasjb 4 years ago

#3 @SergeyBiryukov 4 years ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs. 4 years ago

#5 @audrasjb 4 years ago

​audrasjb commented on ​PR #2257: 4 years ago #6

#7 @audrasjb 4 years ago

#8 @peterwilsoncc 4 years ago