WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54928 closed defect (bug) (fixed)

Twenty Twenty-Two: 404 search label should be translated

Reported by: kjellr's profile kjellr Owned by: audrasjb's profile audrasjb
Milestone: 5.9.1 Priority: normal
Severity: normal Version: 5.9
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

The hidden-404 pattern contains a label that is not marked for translation. We should update this in core after 5.9 is released and mark it for inclusion in 5.9.1.

https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwentytwo/inc/patterns/hidden-404.php#L14

---

Originally reported by @jffng over on GitHub:
​https://github.com/WordPress/twentytwentytwo/issues/342

Change History (8)

This ticket was mentioned in ​PR #2257 on ​WordPress/wordpress-develop by ​walbo.
3 years ago #1

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/54928

#2 @audrasjb
3 years ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

The proposed PR looks good to me and fixes the issue. Marking for commit.

#3 @SergeyBiryukov
3 years ago

  • Summary changed from [Twenty Twenty-Two] 404 search label should be translated to Twenty Twenty-Two: 404 search label should be translated

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#5 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52664:

Twenty Twenty-Two: Make 404 pattern search label and button translatable.

This changes makes the Twenty Twenty-Two "hidden-404" pattern fully prepared for translation.

Props kjellr, walbo.
Fixes #54928.

#7 @audrasjb
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration.

#8 @peterwilsoncc
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52666:

Twenty Twenty-Two: Make 404 pattern search label and button translatable.

This changes makes the Twenty Twenty-Two "hidden-404" pattern fully prepared for translation.

Props kjellr, walbo, audrasjb.
Merges [52664] to the 5.9 branch.
Fixes #54928.

Note: See TracTickets for help on using tickets.